Bug 238485 - [JSC] Remove ExecutableToCodeBlockEdge
Summary: [JSC] Remove ExecutableToCodeBlockEdge
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-03-28 21:03 PDT by Yusuke Suzuki
Modified: 2022-03-31 17:34 PDT (History)
11 users (show)

See Also:

Attachments
Patch (37.42 KB, patch)
2022-03-28 21:04 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (83.40 KB, patch)
2022-03-30 17:35 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (79.69 KB, patch)
2022-03-30 18:23 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (80.91 KB, patch)
2022-03-30 19:28 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (81.99 KB, patch)
2022-03-30 20:40 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (81.69 KB, patch)
2022-03-30 21:22 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (87.44 KB, patch)
2022-03-31 00:05 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (87.46 KB, patch)
2022-03-31 11:38 PDT, Yusuke Suzuki 		keith_miller: review+
Details | Formatted Diff | Diff
Show Obsolete (7) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2022-03-28 21:03:44 PDT 
[JSC] Remove ExecutableToCodeBlockEdge
Comment 1 Yusuke Suzuki 2022-03-28 21:04:12 PDT 
Created attachment 455987 [details]
Patch
Comment 2 Yusuke Suzuki 2022-03-30 17:35:03 PDT 
Created attachment 456188 [details]
Patch
Comment 3 Yusuke Suzuki 2022-03-30 18:23:24 PDT 
Created attachment 456191 [details]
Patch
Comment 4 Yusuke Suzuki 2022-03-30 19:28:42 PDT 
Created attachment 456195 [details]
Patch
Comment 5 Yusuke Suzuki 2022-03-30 20:40:00 PDT 
Created attachment 456197 [details]
Patch
Comment 6 Yusuke Suzuki 2022-03-30 21:22:57 PDT 
Created attachment 456200 [details]
Patch
Comment 7 Yusuke Suzuki 2022-03-31 00:05:54 PDT 
Created attachment 456206 [details]
Patch
Comment 8 Yusuke Suzuki 2022-03-31 11:38:34 PDT 
Created attachment 456262 [details]
Patch
Comment 9 Keith Miller 2022-03-31 13:13:56 PDT 
Comment on attachment 456262 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=456262&action=review

r=me with some comments.

> Source/JavaScriptCore/heap/Heap.h:1075
> +    struct ScriptExecutableSpaceAndSet {

Nit: Maybe this should be ScriptExecutableSpaceAndSets* since there's more than one set in here.

> Source/JavaScriptCore/runtime/FunctionExecutable.cpp:76
> +    // If either of CodeBlocks is not marked yet, we will run output-constraints.

Nit: If either CodeBlock is not marked yet

> Source/JavaScriptCore/runtime/GlobalExecutable.cpp:46
> +        // If the CodeBlocks is not marked yet, we will run output-constraints.

Nit: not plural. It should be CodeBlock.
Comment 10 Yusuke Suzuki 2022-03-31 13:24:14 PDT 
Comment on attachment 456262 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=456262&action=review

Thank you!

>> Source/JavaScriptCore/heap/Heap.h:1075
>> +    struct ScriptExecutableSpaceAndSet {
> 
> Nit: Maybe this should be ScriptExecutableSpaceAndSets* since there's more than one set in here.

Right, fixed.

>> Source/JavaScriptCore/runtime/FunctionExecutable.cpp:76
>> +    // If either of CodeBlocks is not marked yet, we will run output-constraints.
> 
> Nit: If either CodeBlock is not marked yet

Fixed.

>> Source/JavaScriptCore/runtime/GlobalExecutable.cpp:46
>> +        // If the CodeBlocks is not marked yet, we will run output-constraints.
> 
> Nit: not plural. It should be CodeBlock.

Fixed.
Comment 11 Yusuke Suzuki 2022-03-31 17:30:50 PDT 
mac bots are getting stuck, and I cannot get it tested. Landing it since previous mac-wk2 was green (and mac-AS-debug-wk2 failures are fixed locally).
Comment 12 Yusuke Suzuki 2022-03-31 17:33:46 PDT 
Committed r292191 (249094@trunk): <https://commits.webkit.org/249094@trunk>
Comment 13 Radar WebKit Bug Importer 2022-03-31 17:34:18 PDT 
<rdar://problem/91136585>