Bug 238481 – [GLIB] Ubuntu LTS build broken after r291956

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Diego Pino]

[GLIB] Ubuntu LTS build broken after r291956

[Diego Pino]

Created attachment 455982 [details]
Patch

[Diego Pino]

Ubuntu LTS build bot error:

```
../../Source/WebCore/rendering/style/StyleGridData.h:47:59: error: ‘bool WebCore::GridTrackEntrySubgrid::operator==(const WebCore::GridTrackEntrySubgrid&) const’ cannot be defaulted
   47 |     bool operator==(const GridTrackEntrySubgrid&) const = default;
      |                                                           ^~~~~~~
../../Source/WebCore/rendering/style/StyleGridData.h:50:58: error: ‘bool WebCore::GridTrackEntryRepeat::operator==(const WebCore::GridTrackEntryRepeat&) const’ cannot be defaulted
   50 |     bool operator==(const GridTrackEntryRepeat&) const = default;
      |                                                          ^~~~~~~
../../Source/WebCore/rendering/style/StyleGridData.h:56:62: error: ‘bool WebCore::GridTrackEntryAutoRepeat::operator==(const WebCore::GridTrackEntryAutoRepeat&) const’ cannot be defaulted
   56 |     bool operator==(const GridTrackEntryAutoRepeat&) const = default;
      |                                                              ^~~~~~~
```

https://build.webkit.org/#/builders/68/builds/12315/steps/8/logs/stdio

[Diego Pino]

Created attachment 455998 [details]
Patch

[Darin Adler]

Comment on attachment 455998 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=455998&action=review

> Source/WebCore/ChangeLog:3
> +        [GLIB] Ubuntu LTS build broken after r291956

There should not be a "[GLIB]" prefix on a bug like this. I know our rule might be confusing. A "you used a non-portable feature that GCC doesn’t support yet" bug doesn’t need a platform prefix. Or if it did have one, it would be "[GCC]".

[EWS]

/Volumes/Data/worker/Commit-Queue/build/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

[Diego Pino]

Created attachment 456082 [details]
[fast-cq] Patch

[EWS]

Committed r292094 (249014@main): <https://commits.webkit.org/249014@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 456082 [details].

[Radar WebKit Bug Importer]

<rdar://problem/91018313>