Bug 238475 – UTF-8 handling in MediaFragmentURIParser::parseFragments() seems wrong

• Status: NEW
• Component: Media

[Chris Dumez]

UTF-8 handling in MediaFragmentURIParser::parseFragments() seems wrong:

```
        //  b. Convert name and value to Unicode strings by interpreting them as UTF-8. If either
        //     name or value are not valid UTF-8 strings, then remove the name-value pair from the list.
        bool validUTF8 = false;
        if (!name.isEmpty() && !value.isEmpty()) {
            name = String { name.utf8(StrictConversion).data() };
            validUTF8 = !name.isEmpty();

            if (validUTF8) {
                value = String { value.utf8(StrictConversion).data() };
                validUTF8 = !value.isEmpty();
            }
        }
```

Note that `String { }` parses the input string as latin1, not UTF-8. So we're converting to UTF-8 and then back as latin1.

[Chris Dumez]

imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/media_fragment_seek.html seems to be this only WPT test we have that exercises this logic, but doesn't actually seem to cover UTF-8 cases.

[Chris Dumez]

(In reply to Chris Dumez from comment #1)
> imported/w3c/web-platform-tests/html/semantics/embedded-content/media-
> elements/media_fragment_seek.html seems to be this only WPT test we have
> that exercises this logic, but doesn't actually seem to cover UTF-8 cases.

Looks like there are quite a few related tests in media/media-fragments though.

[Radar WebKit Bug Importer]

<rdar://problem/91266173>