Bug 238466 – REGRESSION(r291771): [ iOS ] Text sometimes draw with incorrect color

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Dawn Morningstar]

fast/html/marquee-scroll.html
Is a constant image failure on iOS 

Diff images will be attached, suspected regression point is r291771 due to history pointing to that point.

HISTORY:
https://results.webkit.org/?suite=layout-tests&suite=layout-tests&suite=layout-tests&test=fast%2Fhtml%2Fmarquee-scroll.html&test=imported%2Fw3c%2Fweb-platform-tests%2Ffetch%2Fmetadata%2Fdownload.https.sub.html&test=media%2Fvideo-played-ranges-1.html

DIFF-URL:
https://build.webkit.org/results/Apple-iOS-15-Simulator-Release-WK2-Tests/r291771%20(1978)/fast/html/marquee-scroll-diffs.html

[Radar WebKit Bug Importer]

<rdar://problem/90941790>

[Dawn Morningstar]

Created attachment 455948 [details]
BUG238466 Diff Images

[Simon Fraser (smfr)]

This is a GPU-process-related color failure

[Dawn Morningstar]

(In reply to Simon Fraser (smfr) from comment #3)
> This is a GPU-process-related color failure

Indeed and I saw that r291771 is a GPU-process patch. Are we thinking revert or can this be fixed?

[Simon Fraser (smfr)]

This is a bug that Said is working on.

[Said Abou-Hallawa]

Created attachment 455986 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 455986 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=455986&action=review

Are there any tests that have been marked as flakey that this fixes?

> Source/WebCore/ChangeLog:3
> +        REGRESSION(r291771): [ iOS ] Glyphs should only be recorded after setting the destination GraphicsContext

It's good if the bug title describes the user-visible symptom (e.g. "Text sometimes draw with incorrect color").

[Said Abou-Hallawa]

Created attachment 456005 [details]
Patch

[EWS]

Committed r292026 (248969@main): <https://commits.webkit.org/248969@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 456005 [details].