Bug 238465 - WebCore::LegacyRootInlineBox::lineSnapAdjustment should bail out on grid line height < 1
Summary: WebCore::LegacyRootInlineBox::lineSnapAdjustment should bail out on grid line...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-03-28 13:00 PDT by zalan
Modified: 2022-03-29 12:11 PDT (History)
11 users (show)

See Also:

Attachments
Patch (1.73 KB, patch)
2022-03-28 13:04 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (1.74 KB, patch)
2022-03-29 10:44 PDT, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2022-03-28 13:00:59 PDT 
<rdar://80630664>
Comment 1 zalan 2022-03-28 13:04:01 PDT 
Created attachment 455947 [details]
Patch
Comment 2 Antti Koivisto 2022-03-29 09:30:32 PDT 
Comment on attachment 455947 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=455947&action=review

> Source/WebCore/rendering/LegacyRootInlineBox.cpp:363
> -    if (!gridLineHeight)
> +    if (gridLineHeight < 1)

could this be 

if (!roundToInt(gridLineHeight))

?
Comment 3 zalan 2022-03-29 09:52:57 PDT 
(In reply to Antti Koivisto from comment #2)
> Comment on attachment 455947 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=455947&action=review
> 
> > Source/WebCore/rendering/LegacyRootInlineBox.cpp:363
> > -    if (!gridLineHeight)
> > +    if (gridLineHeight < 1)
> 
> could this be 
> 
> if (!roundToInt(gridLineHeight))
> 
> ?
yes!
Comment 4 zalan 2022-03-29 10:44:27 PDT 
Created attachment 456043 [details]
Patch
Comment 5 EWS 2022-03-29 12:11:16 PDT 
Committed r292054 (248991@main): <https://commits.webkit.org/248991@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 456043 [details].