Bug 238463 - AX ITM: Don't always queue objects for removal if we bail early in AXIsolatedTree::removeSubtreeFromNodeMap
Summary: AX ITM: Don't always queue objects for removal if we bail early in AXIsolated...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tyler Wilcock
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-03-28 11:57 PDT by Tyler Wilcock
Modified: 2022-03-31 04:35 PDT (History)
10 users (show)

See Also:

Attachments
Patch (7.85 KB, patch)
2022-03-30 14:10 PDT, Tyler Wilcock 		no flags Details | Formatted Diff | Diff
Patch (8.15 KB, patch)
2022-03-30 14:22 PDT, Tyler Wilcock 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tyler Wilcock 2022-03-28 11:57:08 PDT 
In both places we call AXIsolatedTree::removeSubtreeFromNodeMap(AXID axID, ...), we unconditionally remove queue axID for removal in AXIsolatedTree::queueChangesAndRemovals.

However, this is sometimes wrong, since AXIsolatedTree::removeSubtreeFromNodeMap can return early without removing axID. We shouldn't be queueing this object for removal in this case.
Comment 1 Radar WebKit Bug Importer 2022-03-28 11:57:21 PDT 
<rdar://problem/90937262>
Comment 2 Tyler Wilcock 2022-03-30 14:10:58 PDT 
Created attachment 456173 [details]
Patch
Comment 3 Tyler Wilcock 2022-03-30 14:22:22 PDT 
Created attachment 456174 [details]
Patch