Bug 238432 - [WebGPU] Implement Queue::writeTexture() according to the spec
Summary: [WebGPU] Implement Queue::writeTexture() according to the spec
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGPU (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-03-27 19:23 PDT by Myles C. Maxfield
Modified: 2022-04-01 00:43 PDT (History)
4 users (show)

See Also:


Attachments
Patch (13.74 KB, patch)
2022-03-27 19:24 PDT, Myles C. Maxfield
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (13.80 KB, patch)
2022-03-28 12:23 PDT, Myles C. Maxfield
no flags Details | Formatted Diff | Diff
Patch (13.79 KB, patch)
2022-03-31 02:00 PDT, Myles C. Maxfield
dino: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2022-03-27 19:23:03 PDT
.
Comment 1 Myles C. Maxfield 2022-03-27 19:24:21 PDT
Created attachment 455879 [details]
Patch
Comment 2 Myles C. Maxfield 2022-03-28 12:23:52 PDT
Created attachment 455942 [details]
Patch
Comment 3 Myles C. Maxfield 2022-03-31 02:00:17 PDT
Created attachment 456221 [details]
Patch
Comment 4 Dean Jackson 2022-03-31 16:36:31 PDT
Comment on attachment 456221 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=456221&action=review

> Source/WebGPU/WebGPU/Queue.mm:299
> +    // file:///Users/mmaxfield/src/GPUWeb/spec/index.html#dom-gpuqueue-writetexture

Oops!

> Source/WebGPU/WebGPU/Queue.mm:487
> +    case WGPUTextureDimension_Force32:
> +        return;

Is this intentionally blank?
Comment 5 Myles C. Maxfield 2022-03-31 21:52:13 PDT
Comment on attachment 456221 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=456221&action=review

>> Source/WebGPU/WebGPU/Queue.mm:487
>> +        return;
> 
> Is this intentionally blank?

Yes. See the explanation in https://bugs.webkit.org/attachment.cgi?id=455884&action=prettypatch
Comment 6 Myles C. Maxfield 2022-03-31 22:01:00 PDT
Committed r292201 (249104@trunk): <https://commits.webkit.org/249104@trunk>
Comment 7 Radar WebKit Bug Importer 2022-03-31 22:01:16 PDT
<rdar://problem/91145076>