RESOLVED FIXED238432
[WebGPU] Implement Queue::writeTexture() according to the spec 
https://bugs.webkit.org/show_bug.cgi?id=238432
Summary [WebGPU] Implement Queue::writeTexture() according to the spec
Myles C. Maxfield
Reported 2022-03-27 19:23:03 PDT
.
Attachments
Patch (13.74 KB, patch)
2022-03-27 19:24 PDT, Myles C. Maxfield 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (13.80 KB, patch)
2022-03-28 12:23 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (13.79 KB, patch)
2022-03-31 02:00 PDT, Myles C. Maxfield 		dino: review+
ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2022-03-27 19:24:21 PDT
Created attachment 455879 [details] Patch
Myles C. Maxfield
Comment 2 2022-03-28 12:23:52 PDT
Created attachment 455942 [details] Patch
Myles C. Maxfield
Comment 3 2022-03-31 02:00:17 PDT
Created attachment 456221 [details] Patch
Dean Jackson
Comment 4 2022-03-31 16:36:31 PDT
Comment on attachment 456221 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=456221&action=review > Source/WebGPU/WebGPU/Queue.mm:299 > + // file:///Users/mmaxfield/src/GPUWeb/spec/index.html#dom-gpuqueue-writetexture Oops! > Source/WebGPU/WebGPU/Queue.mm:487 > + case WGPUTextureDimension_Force32: > + return; Is this intentionally blank?
Myles C. Maxfield
Comment 5 2022-03-31 21:52:13 PDT
Comment on attachment 456221 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=456221&action=review >> Source/WebGPU/WebGPU/Queue.mm:487 >> + return; > > Is this intentionally blank? Yes. See the explanation in https://bugs.webkit.org/attachment.cgi?id=455884&action=prettypatch
Myles C. Maxfield
Comment 6 2022-03-31 22:01:00 PDT
Committed r292201 (249104@trunk): <https://commits.webkit.org/249104@trunk>
Radar WebKit Bug Importer
Comment 7 2022-03-31 22:01:16 PDT
<rdar://problem/91145076>
Note You need to log in before you can comment on or make changes to this bug.