RESOLVED FIXED 238430
[WebGPU] Implement CommandEncoder::copyTextureToBuffer() according to the spec 
https://bugs.webkit.org/show_bug.cgi?id=238430
Summary [WebGPU] Implement CommandEncoder::copyTextureToBuffer() according to the spec
Myles C. Maxfield
Reported 2022-03-27 19:09:31 PDT
.
Attachments
Patch (15.54 KB, patch)
2022-03-27 19:11 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (15.60 KB, patch)
2022-03-28 12:22 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (15.70 KB, patch)
2022-03-31 01:45 PDT, Myles C. Maxfield 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (15.71 KB, patch)
2022-03-31 01:48 PDT, Myles C. Maxfield 		dino: review+
ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2022-03-27 19:11:43 PDT
Created attachment 455876 [details] Patch
Myles C. Maxfield
Comment 2 2022-03-28 12:22:21 PDT
Created attachment 455941 [details] Patch
Myles C. Maxfield
Comment 3 2022-03-31 01:45:22 PDT
Created attachment 456217 [details] Patch
Myles C. Maxfield
Comment 4 2022-03-31 01:48:53 PDT
Created attachment 456218 [details] Patch
Dean Jackson
Comment 5 2022-03-31 16:31:10 PDT
Comment on attachment 456218 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=456218&action=review > Source/WebGPU/WebGPU/CommandEncoder.mm:359 > + // "Let srcTextureDesc be source.texture.[[descriptor]]." This is the first time I've seen this style of spec inclusion. Do we normally include quotation marks. The style I've seen is a link at the top of the function, and then the comments are simply copied in (with the spec items numbers, if needed)
Myles C. Maxfield
Comment 6 2022-03-31 21:45:32 PDT
Comment on attachment 456218 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=456218&action=review >> Source/WebGPU/WebGPU/CommandEncoder.mm:359 >> + // "Let srcTextureDesc be source.texture.[[descriptor]]." > > This is the first time I've seen this style of spec inclusion. Do we normally include quotation marks. > > The style I've seen is a link at the top of the function, and then the comments are simply copied in (with the spec items numbers, if needed) Without quotation marks, how do you know what's a quote and what isn't? You're not the first one to complain about this style, so maybe I should just get rid of all these kinds of comments altogether. I seem to be the only one that thinks they're valuable. I'll do it in a follow-up patch.
Myles C. Maxfield
Comment 7 2022-03-31 21:48:22 PDT
Committed r292199 (249102@trunk): <https://commits.webkit.org/249102@trunk>
Radar WebKit Bug Importer
Comment 8 2022-03-31 21:49:18 PDT
<rdar://problem/91144781>
Note You need to log in before you can comment on or make changes to this bug.