Bug 238403 - [GTK] Create bwrapinfo.json file for xdg-desktop-portal
Summary: [GTK] Create bwrapinfo.json file for xdg-desktop-portal
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Patrick Griffis
URL:
Keywords:
: 267497 (view as bug list)
Depends on:
Blocks: Bubblewrap
  Show dependency tree / graph
 
Reported: 2022-03-25 19:22 PDT by Patrick Griffis
Modified: 2024-01-22 17:26 PST (History)
4 users (show)

See Also:

Attachments
Patch (5.27 KB, patch)
2022-03-25 19:23 PDT, Patrick Griffis 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Griffis 2022-03-25 19:22:53 PDT 
[GTK] Create bwrapinfo.json file for xdg-desktop-portal
Comment 1 Patrick Griffis 2022-03-25 19:23:56 PDT 
Created attachment 455814 [details]
Patch
Comment 2 Patrick Griffis 2022-03-25 19:25:41 PDT 
This works around a crash in xdg-desktop-portal 1.12.1 and 1.14.0: https://github.com/flatpak/xdg-desktop-portal/issues/709

I have fixed this in future xdg-desktop-portal releases: https://github.com/flatpak/xdg-desktop-portal/pull/746

However the feature is not fully functioning: https://github.com/flatpak/xdg-desktop-portal/issues/747
Comment 3 Michael Catanzaro 2022-03-26 08:45:45 PDT 
You intentionally did not set r? here, right?
Comment 4 Patrick Griffis 2022-03-26 08:50:59 PDT 
(In reply to Michael Catanzaro from comment #3)
> You intentionally did not set r? here, right?

Yeah, as-is it doesn't really work, so I guess it was more just to track the issue and document the progress towards getting it working.
Comment 5 Patrick Griffis 2024-01-22 10:23:19 PST 
Pull request: https://github.com/WebKit/WebKit/pull/23052
Comment 6 Michael Catanzaro 2024-01-22 10:26:02 PST 
*** Bug 267497 has been marked as a duplicate of this bug. ***
Comment 7 tekstryder 2024-01-22 12:29:35 PST 
I built webkit2gtk-4.1 2.42.4 + https://github.com/WebKit/WebKit/pull/23052, and can confirm it resolved my original issue reported in bug 267497.

Thanks!
Comment 8 EWS 2024-01-22 17:26:56 PST 
Committed 273334@main (b9361c774194): <https://commits.webkit.org/273334@main>

Reviewed commits have been landed. Closing PR #23052 and removing active labels.