Bug 238402 – Don't create directories on iOS if we are only using ephemeral storages

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Alex Christensen]

Don't create directories on iOS if we are only using ephemeral storages

[Alex Christensen]

Created attachment 455813 [details]
Patch

[Chris Dumez]

Looks like iOS failures may be real?

[Alex Christensen]

Comment on attachment 455813 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=455813&action=review

> Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:334
> +    if (!process.sessionID().isEphemeral()) {

This was asserting because when we initialize the web process we don't always have a session ID yet.  I'm moving this to WebProcess::setWebsiteDataStoreParameters

[Alex Christensen]

Created attachment 455929 [details]
Patch

[Chris Dumez]

Comment on attachment 455929 [details]
Patch

r=me assuming the bots are happy.

[Sihui Liu]

Comment on attachment 455929 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=455929&action=review

> Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp:290
> +        m_cookieStorageDirectory = resolveAndCreateReadWriteDirectoryForSandboxExtension(WebProcessPool::cookieStorageDirectory());

It's a bit weird that WebsiteDataStore asks WebProcessPool for directory. I
If we think the directory is per WebsiteDataStore, maybe we should move cookieStorageDirectory() to WebsiteDataStore? 
If we don't think it's per WebsiteDataStore, maybe we should not send it in WebsiteDataStoreParameters?

> Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp:1905
> +        if (String cookieStorageDirectory = WebProcessPool::cookieStorageDirectory(); !cookieStorageDirectory.isEmpty())

If we already call resolveDirectoriesIfNecessary() above, shouldn't we just check if (!m_cookieStorageDirectory.isEmpty())?

[Alex Christensen]

This is indeed weird code that is quite old so I'm trying to minimize functional changes.  It is taking another step in its transition from process pool to data store.

[Alex Christensen]

r292068

[Alex Christensen]

(by the way, I agree with Sihui's cleanup suggestions and think they should be done, but not right now)

[Radar WebKit Bug Importer]

<rdar://problem/91022750>

[David Kilzer (:ddkilzer)]

<rdar://problem/79639418>