Bug 23839 - REGRESSION(r40254): Definition terms with display style of run-in display :after content like :before content
Summary: REGRESSION(r40254): Definition terms with display style of run-in display :af...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac (Intel) OS X 10.5
: P1 Normal
Assignee: Dave Hyatt
URL: https://ironmoney.com/api/statuses/
Keywords: HasReduction, InRadar, Regression
Depends on:
Blocks:
 
Reported: 2009-02-08 22:27 PST by Chasen Le Hara
Modified: 2009-02-08 23:17 PST (History)
2 users (show)

See Also:

Attachments
Test case (405 bytes, text/html)
2009-02-08 22:30 PST, Chasen Le Hara 		no flags Details
Patch (22.12 KB, patch)
2009-02-08 23:12 PST, Dave Hyatt 		sam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chasen Le Hara 2009-02-08 22:27:27 PST 
Content defined with the :after pseudo-element appears before the term in a definition list when the display is set to run-in.

It should appear after the term instead of before the term.

This is a regression (works in current versions of Safari on the Mac and was working in nightlies until sometime early last week).
Comment 1 Chasen Le Hara 2009-02-08 22:30:02 PST 
Created attachment 27477 [details]
Test case

The term should have a colon after it instead of before it.
Comment 2 Mark Rowe (bdash) 2009-02-08 22:36:49 PST 
<rdar://problem/6567717>
Comment 3 Mark Rowe (bdash) 2009-02-08 22:43:15 PST 
<http://trac.webkit.org/changeset/40254>
Comment 4 Dave Hyatt 2009-02-08 23:12:34 PST 
Created attachment 27478 [details]
Patch
Comment 5 Sam Weinig 2009-02-08 23:13:56 PST 
Comment on attachment 27478 [details]
Patch

r=me

> ===================================================================
> --- LayoutTests/fast/runin/002.html	(revision 0)
> +++ LayoutTests/fast/runin/002.html	(revision 0)
> @@ -0,0 +1,17 @@
> +<!DOCTYPE html>
> +<html>
> +	<head>
> +		<title>WebKit Bug 23839: Definition terms with display style of run-in display :after content like :before content</title>
> +		<link href="http://chasenlehara.com/" rel="author" title="Chasen Le Hara" />
> +		<style type="text/css">
> +dt {display: run-in}
> +dt:after {content: ":"}
> +		</style>
> +	</head>
> +	<body>
> +		<dl>
> +			<dt>Term</dt>
> +			<dd>Definition</dd>
> +		</dl>
> +	</body>
> +</html>
> \ No newline at end of file

Missing newline.
Comment 6 Dave Hyatt 2009-02-08 23:17:09 PST 
Fixed in r40778.