Bug 238381 – Fix runtime expose scope check for shadow realms

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Joseph Griego]

Fix runtime expose scope check for shadow realms

[Joseph Griego]

Created attachment 455774 [details]
Patch

[Joseph Griego]

Created attachment 455798 [details]
Patch

update binding test expectations

[Radar WebKit Bug Importer]

<rdar://problem/91166867>

[Darin Adler]

Comment on attachment 455798 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=455798&action=review

> Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:4010
> +      return "([&] { auto* base = $globalObjectPtr; auto obj = jsDynamicCast<$wrapperType*>(base->vm(), base); return obj && $sideCondition; })()";

WebKit coding style uses words rather than non-word abbreviations. So this would be "object" rather than "obj". Same in the many other cases below and above.

[Joseph Griego]

Thanks Darin, and apologies; I need to add a pre-commit hook for myself to yell when a variable is named `obj`! Old habits are hard to break

[Joseph Griego]

Created attachment 457120 [details]
Patch

[Joseph Griego]

Created attachment 457810 [details]
Patch

[EWS]

Committed r293021 (249760@main): <https://commits.webkit.org/249760@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 457810 [details].