Bug 238359 - Mismatched forward declaration of GraphicsContextState
Summary: Mismatched forward declaration of GraphicsContextState
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Don Olmstead
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-03-24 17:35 PDT by Don Olmstead
Modified: 2022-03-25 00:45 PDT (History)
2 users (show)

See Also:

Attachments
Patch (1.09 KB, patch)
2022-03-24 17:37 PDT, Don Olmstead 		darin: review+
Details | Formatted Diff | Diff
Patch (1.13 KB, patch)
2022-03-24 17:51 PDT, Don Olmstead 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Don Olmstead 2022-03-24 17:35:29 PDT 
Its a class not a struct
Comment 1 Don Olmstead 2022-03-24 17:37:32 PDT 
Created attachment 455711 [details]
Patch
Comment 2 Darin Adler 2022-03-24 17:48:47 PDT 
Comment on attachment 455711 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=455711&action=review

> Source/WebCore/platform/graphics/cairo/CairoOperations.h:51
> +class GraphicsContextState;

Should sort in with other class forward declarations above and merge into that paragraph.
Comment 3 Don Olmstead 2022-03-24 17:51:08 PDT 
Created attachment 455715 [details]
Patch
Comment 4 Don Olmstead 2022-03-24 17:51:27 PDT 
(In reply to Darin Adler from comment #2)
> Comment on attachment 455711 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=455711&action=review
> 
> > Source/WebCore/platform/graphics/cairo/CairoOperations.h:51
> > +class GraphicsContextState;
> 
> Should sort in with other class forward declarations above and merge into
> that paragraph.

Good catch! Patch updated
Comment 5 EWS 2022-03-25 00:44:49 PDT 
Committed r291850 (248862@main): <https://commits.webkit.org/248862@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 455715 [details].
Comment 6 Radar WebKit Bug Importer 2022-03-25 00:45:18 PDT 
<rdar://problem/90823281>