Bug 238355 - String::split() should take in a StringView instead of a String
Summary: String::split() should take in a StringView instead of a String
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-03-24 16:24 PDT by Chris Dumez
Modified: 2022-03-24 21:24 PDT (History)
17 users (show)

See Also:

Attachments
Patch (7.54 KB, patch)
2022-03-24 17:03 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2022-03-24 16:24:53 PDT 
String::split() should take in a StringView instead of a String, to avoid unnecessary construction of Strings in some instances.
Comment 1 Chris Dumez 2022-03-24 17:03:17 PDT 
Created attachment 455705 [details]
Patch
Comment 2 Geoffrey Garen 2022-03-24 19:44:29 PDT 
Comment on attachment 455705 [details]
Patch

r=me
Comment 3 EWS 2022-03-24 21:22:59 PDT 
Committed r291848 (248860@main): <https://commits.webkit.org/248860@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 455705 [details].
Comment 4 Radar WebKit Bug Importer 2022-03-24 21:24:15 PDT 
<rdar://problem/90816865>