WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
238351
After
r291814
, we need to create the INSTALL_PATH for the iOS sandbox files
https://bugs.webkit.org/show_bug.cgi?id=238351
Summary
After r291814, we need to create the INSTALL_PATH for the iOS sandbox files
Michael Saboff
Reported
2022-03-24 15:51:10 PDT
Before
r291814
, some of the iOS sandbox files were copied to $(INSTALL_PATH). That built in Xcode copying stpe created the INSTALL_PATH directory. When the output of the preprocessed .sb.in files where copied to $(INSTALL_PATH), it already existed.
r291814
made it so that all of the iOS sandbox files are preprocessed and then copied to $(INSTALL_PATH) using the "cp" command. The problem is that $(INSTALL_PATH) hasn't been created yet. This appears to only manifest in the Apple build system and not local builds.
Attachments
Patch
(2.65 KB, patch)
2022-03-24 16:03 PDT
,
Michael Saboff
saam
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Michael Saboff
Comment 1
2022-03-24 15:51:28 PDT
<
rdar://90794287
>
Michael Saboff
Comment 2
2022-03-24 16:03:06 PDT
Created
attachment 455698
[details]
Patch
Saam Barati
Comment 3
2022-03-24 16:07:11 PDT
Comment on
attachment 455698
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=455698&action=review
r=me
> Source/WebKit/ChangeLog:11 > + That change set made it soe that all WebKit iOS sandbox profile files are preprocessed
soe => so
Alexey Proskuryakov
Comment 4
2022-03-24 16:24:09 PDT
I was going to ask if we need to add the directory to output paths because of this, then noticed that there aren't any inputs or outputs here.
Michael Saboff
Comment 5
2022-03-24 16:38:40 PDT
Committed
r291828
(
248850@trunk
): <
https://commits.webkit.org/248850@trunk
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug