WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 238336
Start preparing WebCore for making the String(const char*) constructor explicit
https://bugs.webkit.org/show_bug.cgi?id=238336
Summary
Start preparing WebCore for making the String(const char*) constructor explicit
Chris Dumez
Reported
2022-03-24 10:51:22 PDT
Start preparing WebCore for making the String(const char*) constructor explicit. Making this constructor explicit helps catch at compile time cases where the ""_s prefix is missing on String literals.
Attachments
Patch
(415.80 KB, patch)
2022-03-24 13:16 PDT
,
Chris Dumez
ews-feeder
: commit-queue-
Details
Formatted Diff
Diff
Patch
(421.05 KB, patch)
2022-03-24 13:32 PDT
,
Chris Dumez
ews-feeder
: commit-queue-
Details
Formatted Diff
Diff
Patch
(421.06 KB, patch)
2022-03-24 14:51 PDT
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
Patch
(423.63 KB, patch)
2022-03-24 14:56 PDT
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
Patch
(423.63 KB, patch)
2022-03-24 16:14 PDT
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
Patch
(419.56 KB, patch)
2022-03-24 17:44 PDT
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
Patch
(416.82 KB, patch)
2022-03-24 19:48 PDT
,
Chris Dumez
ews-feeder
: commit-queue-
Details
Formatted Diff
Diff
Patch
(411.77 KB, patch)
2022-03-24 20:59 PDT
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
Patch
(411.36 KB, patch)
2022-03-24 21:58 PDT
,
Chris Dumez
ews-feeder
: commit-queue-
Details
Formatted Diff
Diff
Patch
(411.72 KB, patch)
2022-03-24 22:37 PDT
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
Patch
(412.49 KB, patch)
2022-03-25 07:23 PDT
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
Show Obsolete
(10)
View All
Add attachment
proposed patch, testcase, etc.
Chris Dumez
Comment 1
2022-03-24 13:16:46 PDT
Created
attachment 455670
[details]
Patch
Chris Dumez
Comment 2
2022-03-24 13:32:15 PDT
Created
attachment 455672
[details]
Patch
Chris Dumez
Comment 3
2022-03-24 14:51:44 PDT
Created
attachment 455688
[details]
Patch
Chris Dumez
Comment 4
2022-03-24 14:56:14 PDT
Created
attachment 455691
[details]
Patch
Chris Dumez
Comment 5
2022-03-24 16:14:34 PDT
Created
attachment 455700
[details]
Patch
Chris Dumez
Comment 6
2022-03-24 17:44:36 PDT
Created
attachment 455713
[details]
Patch
Chris Dumez
Comment 7
2022-03-24 19:48:58 PDT
Created
attachment 455719
[details]
Patch
Chris Dumez
Comment 8
2022-03-24 20:59:47 PDT
Created
attachment 455722
[details]
Patch
Chris Dumez
Comment 9
2022-03-24 21:58:44 PDT
Created
attachment 455723
[details]
Patch
Chris Dumez
Comment 10
2022-03-24 22:37:54 PDT
Created
attachment 455724
[details]
Patch
Chris Dumez
Comment 11
2022-03-25 07:23:10 PDT
Created
attachment 455757
[details]
Patch
Geoffrey Garen
Comment 12
2022-03-25 10:01:24 PDT
Comment on
attachment 455757
[details]
Patch r=me
Chris Dumez
Comment 13
2022-03-25 10:13:20 PDT
Comment on
attachment 455757
[details]
Patch Clearing flags on attachment: 455757 Committed
r291863
(
248870@trunk
): <
https://commits.webkit.org/248870@trunk
>
Chris Dumez
Comment 14
2022-03-25 10:13:28 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 15
2022-03-25 10:14:21 PDT
<
rdar://problem/90843719
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug