238334 – Do not use std::numeric_limits<float>::min() as the initial value to collect max values for glyph overflow

Bug 238334 - Do not use std::numeric_limits<float>::min() as the initial value to collect max values for glyph overflow

Summary: Do not use std::numeric_limits<float>::min() as the initial value to collect ...

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	Layout and Rendering (show other bugs)
Version:	Other
Hardware:	Unspecified Unspecified

Importance:	P2 Normal
Assignee:	zalan

URL:
Keywords:	InRadar

Depends on:
Blocks:

Reported:	2022-03-24 10:23 PDT by zalan
Modified:	2022-04-08 08:02 PDT (History)
CC List:	8 users (show)

See Also:

Attachments
Patch (2.75 KB, patch) 2022-03-24 10:34 PDT, zalan	no flags	Details \| Formatted Diff \| Diff
Patch (73.99 KB, patch) 2022-03-25 06:12 PDT, zalan	no flags	Details \| Formatted Diff \| Diff
Patch (75.17 KB, patch) 2022-04-07 15:03 PDT, zalan	no flags	Details \| Formatted Diff \| Diff
Patch (78.76 KB, patch) 2022-04-08 05:42 PDT, zalan	no flags	Details \| Formatted Diff \| Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description zalan 2022-03-24 10:23:56 PDT

It has the side effect of a "never empty glyph vertical overflow"  ( ceilf(std::max(0, std::min)) -> 1px )

Comment 1 zalan 2022-03-24 10:34:38 PDT

Created attachment 455650 [details]
Patch

Comment 2 Simon Fraser (smfr) 2022-03-24 11:33:18 PDT

Comment on attachment 455650 [details]
Patch

Is there a behavior change here? No tests change?

Comment 3 zalan 2022-03-24 12:17:14 PDT

(In reply to Simon Fraser (smfr) from comment #2)
> Comment on attachment 455650 [details]
> Patch
> 
> Is there a behavior change here? No tests change?
Yes, I am using EWS to collect the new baseline.

Comment 4 zalan 2022-03-25 06:12:00 PDT

Created attachment 455752 [details]
Patch

Comment 5 Radar WebKit Bug Importer 2022-03-31 10:24:15 PDT

<rdar://problem/91111725>

Comment 6 zalan 2022-04-07 15:03:36 PDT

Created attachment 456973 [details]
Patch

Comment 7 zalan 2022-04-08 05:42:46 PDT

Created attachment 457057 [details]
Patch

Comment 8 EWS 2022-04-08 08:01:56 PDT

Committed r292606 (249438@main): <https://commits.webkit.org/249438@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 457057 [details].