Bug 238311 - [WebGPU] Implement Texture::createView() according to the spec
Summary: [WebGPU] Implement Texture::createView() according to the spec
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGPU (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords: InRadar
Depends on: 238427
Blocks: 238367 238428
  Show dependency tree / graph
 
Reported: 2022-03-23 23:08 PDT by Myles C. Maxfield
Modified: 2022-03-31 01:27 PDT (History)
4 users (show)

See Also:

Attachments
Patch (35.84 KB, patch)
2022-03-23 23:19 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (35.91 KB, patch)
2022-03-24 15:58 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (32.14 KB, patch)
2022-03-26 21:38 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (51.77 KB, patch)
2022-03-27 11:17 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (28.12 KB, patch)
2022-03-27 18:47 PDT, Myles C. Maxfield 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (27.87 KB, patch)
2022-03-27 22:04 PDT, Myles C. Maxfield 		kkinnunen: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2022-03-23 23:08:29 PDT 
[WebGPU] Implement Texture::createView() according to the spec
Comment 1 Myles C. Maxfield 2022-03-23 23:19:14 PDT 
Created attachment 455611 [details]
Patch
Comment 2 Myles C. Maxfield 2022-03-24 11:08:47 PDT 
Comment on attachment 455611 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=455611&action=review

> Source/WebGPU/WebGPU/Texture.mm:1934
> +            textureType = MTLTextureType2DMultisampleArray;

This needs to be guarded. https://commits.webkit.org/r291805
Comment 3 Myles C. Maxfield 2022-03-24 15:58:56 PDT 
Created attachment 455696 [details]
Patch
Comment 4 Myles C. Maxfield 2022-03-26 21:38:55 PDT 
Created attachment 455863 [details]
Patch
Comment 5 Myles C. Maxfield 2022-03-27 11:17:06 PDT 
Created attachment 455866 [details]
Patch
Comment 6 Myles C. Maxfield 2022-03-27 18:47:11 PDT 
Created attachment 455874 [details]
Patch
Comment 7 Myles C. Maxfield 2022-03-27 22:04:36 PDT 
Created attachment 455887 [details]
Patch
Comment 8 Kimmo Kinnunen 2022-03-30 00:27:01 PDT 
Comment on attachment 455887 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=455887&action=review

> Source/WebGPU/WebGPU/Texture.mm:1795
> +        // "set resolved.mipLevelCount to texture.[[descriptor]].mipLevelCount â resolved.baseMipLevel."

non-ascii chars in comment

> Source/WebGPU/WebGPU/Texture.mm:1841
> +            // "Set resolved.arrayLayerCount to texture.[[descriptor]].size.depthOrArrayLayers â baseArrayLayer."

non-ascii

> Source/WebGPU/WebGPU/Texture.mm:2031
> +    std::optional<MTLPixelFormat> pixelFormat = MTLPixelFormatInvalid;

Either:
  std::optional<MTLPixelFormat> pixelFormat;
or:
  MTLPixelFormat pixelFormat = MTLPixelFormatInvalid;

not both?
Comment 9 Radar WebKit Bug Importer 2022-03-30 23:09:15 PDT 
<rdar://problem/91087004>
Comment 10 Myles C. Maxfield 2022-03-31 01:27:09 PDT 
Committed r292145 (249052@trunk): <https://commits.webkit.org/249052@trunk>