Bug 23831 - [CAIRO] build broken by TransformationMatrix rework
Summary: [CAIRO] build broken by TransformationMatrix rework
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Gustavo Noronha (kov)
URL:
Keywords: Cairo
Depends on:
Blocks:
 
Reported: 2009-02-08 07:08 PST by Gustavo Noronha (kov)
Modified: 2009-02-08 11:50 PST (History)
2 users (show)

See Also:

Attachments
proposed fix (9.39 KB, patch)
2009-02-08 07:46 PST, Gustavo Noronha (kov) 		no flags Details | Formatted Diff | Diff
fixed proposed fix =) (9.32 KB, patch)
2009-02-08 08:13 PST, Gustavo Noronha (kov) 		no flags Details | Formatted Diff | Diff
working proposed fix (9.76 KB, patch)
2009-02-08 11:24 PST, Gustavo Noronha (kov) 		simon.fraser: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gustavo Noronha (kov) 2009-02-08 07:08:41 PST 
WebKit/GTK+ build is broken because the cairo backend has not been updated after the changes to TransformationMatrix on 40761.
Comment 1 Gustavo Noronha (kov) 2009-02-08 07:46:25 PST 
Created attachment 27463 [details]
proposed fix
Comment 2 Gustavo Noronha (kov) 2009-02-08 08:13:22 PST 
Created attachment 27464 [details]
fixed proposed fix =)
Comment 3 Gustavo Noronha (kov) 2009-02-08 11:24:49 PST 
Created attachment 27468 [details]
working proposed fix

thanks to krit for pointing me to the right direction on the fix =)
Comment 4 Simon Fraser (smfr) 2009-02-08 11:30:37 PST 
Comment on attachment 27468 [details]
working proposed fix


>  #if PLATFORM(CG)
>      operator CGAffineTransform() const;
> +#elif PLATFORM(CAIRO)
> +    operator cairo_matrix_t() const;
>  #endif

Your patch is slightly out of date here; there's a new #if PLATFORM(QT) section. Please convert to a series of #elif on commit.

r=me
Comment 5 Dirk Schulze 2009-02-08 11:50:46 PST 
landed in r40774