WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
23831
[CAIRO] build broken by TransformationMatrix rework
https://bugs.webkit.org/show_bug.cgi?id=23831
Summary
[CAIRO] build broken by TransformationMatrix rework
Gustavo Noronha (kov)
Reported
2009-02-08 07:08:41 PST
WebKit/GTK+ build is broken because the cairo backend has not been updated after the changes to TransformationMatrix on 40761.
Attachments
proposed fix
(9.39 KB, patch)
2009-02-08 07:46 PST
,
Gustavo Noronha (kov)
no flags
Details
Formatted Diff
Diff
fixed proposed fix =)
(9.32 KB, patch)
2009-02-08 08:13 PST
,
Gustavo Noronha (kov)
no flags
Details
Formatted Diff
Diff
working proposed fix
(9.76 KB, patch)
2009-02-08 11:24 PST
,
Gustavo Noronha (kov)
simon.fraser
: review+
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Gustavo Noronha (kov)
Comment 1
2009-02-08 07:46:25 PST
Created
attachment 27463
[details]
proposed fix
Gustavo Noronha (kov)
Comment 2
2009-02-08 08:13:22 PST
Created
attachment 27464
[details]
fixed proposed fix =)
Gustavo Noronha (kov)
Comment 3
2009-02-08 11:24:49 PST
Created
attachment 27468
[details]
working proposed fix thanks to krit for pointing me to the right direction on the fix =)
Simon Fraser (smfr)
Comment 4
2009-02-08 11:30:37 PST
Comment on
attachment 27468
[details]
working proposed fix
> #if PLATFORM(CG) > operator CGAffineTransform() const; > +#elif PLATFORM(CAIRO) > + operator cairo_matrix_t() const; > #endif
Your patch is slightly out of date here; there's a new #if PLATFORM(QT) section. Please convert to a series of #elif on commit. r=me
Dirk Schulze
Comment 5
2009-02-08 11:50:46 PST
landed in
r40774
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug