Bug 23829 - Make createElement non-virtual
Summary: Make createElement non-virtual
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Julien Chaffraix
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-02-08 01:07 PST by Julien Chaffraix
Modified: 2009-03-17 13:21 PDT (History)
0 users

See Also:

Attachments
Proposed fix: inline HTMLDocument::createElement into Document's (5.17 KB, patch)
2009-02-08 01:32 PST, Julien Chaffraix 		ap: review-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Julien Chaffraix 2009-02-08 01:07:57 PST 
As mentioned in https://bugs.webkit.org/show_bug.cgi?id=14506#c9, it would be nice to remove the forked version in HTMLDocument. It is the only other specialization so we can make createElement non-virtual afterwards.

Patch forthcoming.
Comment 1 Julien Chaffraix 2009-02-08 01:32:33 PST 
Created attachment 27461 [details]
Proposed fix: inline HTMLDocument::createElement into Document's
Comment 2 Alexey Proskuryakov 2009-02-09 04:48:14 PST 
Comment on attachment 27461 [details]
Proposed fix: inline HTMLDocument::createElement into Document's

r=me
Comment 3 Alexey Proskuryakov 2009-02-09 04:56:35 PST 
Comment on attachment 27461 [details]
Proposed fix: inline HTMLDocument::createElement into Document's

I've just had a second thought after noticing that isHTMLDocument() is virtual. This patch doesn't cut back on virtual dispatches in most cases, but adds a branch, so I don't see how it is an improvement.

Taking back the r=me, sorry.
Comment 4 Julien Chaffraix 2009-03-17 13:21:19 PDT 
After a second thought, it goes against some of the latest changes. Also making HTMLDocument() non virtual to offset the cost of the introduced branch is not really an amelioration in term of code cleanliness. Closing this bug as WONTFIX.