Bug 238248 - REGRESSION(r291611): Fix GTK/WPE build
Summary: REGRESSION(r291611): Fix GTK/WPE build
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Linux
: P2 Normal
Assignee: Víctor M. Jáquez L.
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-03-23 02:56 PDT by Víctor M. Jáquez L.
Modified: 2022-03-23 09:48 PDT (History)
10 users (show)

See Also:

Attachments
Patch (3.26 KB, patch)
2022-03-23 03:04 PDT, Víctor M. Jáquez L. 		no flags Details | Formatted Diff | Diff
Patch (3.22 KB, patch)
2022-03-23 03:13 PDT, Víctor M. Jáquez L. 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Víctor M. Jáquez L. 2022-03-23 02:56:34 PDT 
It seems that the CI doesn't compile GTK/WPE webrtc branch using libwebrtc.

Unreviewed build fix patch on the way.
Comment 1 Víctor M. Jáquez L. 2022-03-23 03:04:29 PDT 
Created attachment 455479 [details]
Patch
Comment 2 EWS 2022-03-23 03:07:10 PDT 
ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!.
Comment 3 youenn fablet 2022-03-23 03:07:27 PDT 
Thanks for the fix, I thought I fixed these bugs before committing, sorry about that.
Comment 4 Víctor M. Jáquez L. 2022-03-23 03:13:09 PDT 
Created attachment 455481 [details]
Patch
Comment 5 EWS 2022-03-23 06:11:56 PDT 
Committed r291743 (248775@main): <https://commits.webkit.org/248775@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 455481 [details].
Comment 6 Radar WebKit Bug Importer 2022-03-23 09:48:02 PDT 
<rdar://problem/90705292>