calc(): Handle finite value with infinite step in round()

[Nikos Mouchtaris]

Handle finite value with infinite step in round() from css/css-values/round-function.html

[Nikos Mouchtaris]

Created attachment 455445 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 455445 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=455445&action=review

> Source/WebCore/css/calc/CSSCalcPrimitiveValueNode.cpp:89
> +        m_value = CSSPrimitiveValue::create(signbit(m_value->doubleValue()) ? -std::numeric_limits<double>::infinity() : std::numeric_limits<double>::infinity(), m_value->primitiveType());

can this use copysign()?

[Nikos Mouchtaris]

Created attachment 455684 [details]
Patch

[Nikos Mouchtaris]

(In reply to Simon Fraser (smfr) from comment #2)
> Comment on attachment 455445 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=455445&action=review
> 
> > Source/WebCore/css/calc/CSSCalcPrimitiveValueNode.cpp:89
> > +        m_value = CSSPrimitiveValue::create(signbit(m_value->doubleValue()) ? -std::numeric_limits<double>::infinity() : std::numeric_limits<double>::infinity(), m_value->primitiveType());
> 
> can this use copysign()?

Fixed.

[EWS]

Committed r291841 (248855@main): <https://commits.webkit.org/248855@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 455684 [details].

[Radar WebKit Bug Importer]

<rdar://problem/90809047>