Bug 238210 - Swap all RemoteLayerBackingStore buffers in a single IPC
Summary: Swap all RemoteLayerBackingStore buffers in a single IPC
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Process Model (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
: 238000 (view as bug list)
Depends on:
Blocks:
 
Reported: 2022-03-22 11:02 PDT by Simon Fraser (smfr)
Modified: 2022-03-23 12:09 PDT (History)
3 users (show)

See Also:

Attachments
Patch (42.04 KB, patch)
2022-03-22 11:10 PDT, Simon Fraser (smfr) 		thorton: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (43.67 KB, patch)
2022-03-22 12:18 PDT, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2022-03-22 11:02:50 PDT 
Swap all RemoteLayerBackingStore buffers in a single IPC
Comment 1 Simon Fraser (smfr) 2022-03-22 11:10:06 PDT 
Created attachment 455399 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2022-03-22 11:10:34 PDT 
<rdar://problem/90648100>
Comment 3 Tim Horton 2022-03-22 11:15:34 PDT 
Comment on attachment 455399 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=455399&action=review

> Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStore.mm:266
> +            WebCore::IntRect indicatorRect(0, 0, 52, 27);

Maybe `platformCALayerShowRepaintCounter` should populate an out arg or something? Now we have this in two places
Comment 4 Simon Fraser (smfr) 2022-03-22 12:18:26 PDT 
Created attachment 455410 [details]
Patch
Comment 5 EWS 2022-03-22 19:07:47 PDT 
Committed r291733 (?): <https://commits.webkit.org/r291733>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 455410 [details].
Comment 6 Simon Fraser (smfr) 2022-03-23 12:09:03 PDT 
*** Bug 238000 has been marked as a duplicate of this bug. ***