Bug 23821 – [GTK] On win, PluginMessageWin* and PluginMessageThrottlerWin need to be built too

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Adrien Nader]

WebCore/{PluginDatabaseWin.cpp, PluginDatabaseWin.h, PluginMessageThrottlerWin.cpp, PluginMessageThrottlerWin.h} need to be built too when building webkit-gtk for windows.

[Adrien Nader]

Created attachment 27449 [details]
Conditionaly add PluginDatabaseWin.{h, cpp} and PluginMessageThrottlerWin.{h, cpp} to webcoregtk_source in WebCore/GNUmakefile.am

Conditionaly add PluginDatabaseWin.{h, cpp} and PluginMessageThrottlerWin.{h, cpp} to webcoregtk_source in WebCore/GNUmakefile.am.
Sorry for the lack of changelog, I'm mostly preoccupied with the patch being correct.

[Holger Freyther]

Comment on attachment 27449 [details]
Conditionaly add PluginDatabaseWin.{h, cpp} and PluginMessageThrottlerWin.{h, cpp} to webcoregtk_source in WebCore/GNUmakefile.am

Please see http://webkit.org/coding/contributing.html and follow step four and attach a patch with a changelog entry.

thanks

[Holger Freyther]

The patch is even not correct. it _sources and not _source... and you will get duplicated symbols because PluginDatabase.cpp and PluginDatabaseWin.cpp will be compiled.

[Adrien Nader]

Holger, oh right, I actually some other patch which was :
-webcoregtk_source += \
+webcoregtk_sources += \

 =/ 


As for the duplicated symbols, thanks for pointing that out, I had completely missed them. Grasping all the details of a build system is hard.

[Adrien Nader]

Trying to solve the duplicated symbols problem made me compare PluginDatabase.cpp and win/PluginDatabaseWin.cpp. There are several windows-specific functions which are duplicated accross both files (inside an #ifdef/#endif pair if inside PluginDatabase.cpp).
Should they be reunified ? Maybe partially ? If so should windows-specific functions be moved to PluginDatabaseWin.cpp or be inside PluginDatabase.cpp and only conditionnally compiled ?

[Jan Alonzo]

This seems fixed already.