Bug 238198 - [GTK][WPE] Remove the ATK implementation
Summary: [GTK][WPE] Remove the ATK implementation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2022-03-22 03:29 PDT by Carlos Garcia Campos
Modified: 2022-03-24 04:40 PDT (History)
17 users (show)

See Also:

Attachments
Patch (479.33 KB, patch)
2022-03-22 03:36 PDT, Carlos Garcia Campos 		aperez: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2022-03-22 03:29:24 PDT 
It's been replaced by new ATSPI implementation.
Comment 1 Carlos Garcia Campos 2022-03-22 03:36:03 PDT 
Created attachment 455358 [details]
Patch
Comment 2 Adrian Perez 2022-03-22 04:17:37 PDT 
Comment on attachment 455358 [details]
Patch

Nice to see so much code go away 💣️
Comment 3 Carlos Garcia Campos 2022-03-22 06:35:26 PDT 
Committed r291613 (?): <https://commits.webkit.org/r291613>
Comment 4 Michael Catanzaro 2022-03-23 15:37:26 PDT 
I'm seeing a build failure:

In file included from /home/mcatanzaro/Projects/WebKit/Source/WebKit/UIProcess/API/glib/WebKitWebViewAccessible.cpp:21:
/home/mcatanzaro/Projects/WebKit/Source/WebKit/UIProcess/API/glib/WebKitWebViewAccessible.h:24:10: fatal error: atk/atk.h: No such file or directory
   24 | #include <atk/atk.h>
      |          ^~~~~~~~~~~
compilation terminated.

That's when building with -DUSE_GTK4=ON. WebKitWebViewAccessible still depends on AtkSocket. Maybe with GTK 3 the include dirs are inherited from GTK?
Comment 5 Adrian Perez 2022-03-23 16:25:28 PDT 
(In reply to Michael Catanzaro from comment #4)
> I'm seeing a build failure:
> 
> In file included from
> /home/mcatanzaro/Projects/WebKit/Source/WebKit/UIProcess/API/glib/
> WebKitWebViewAccessible.cpp:21:
> /home/mcatanzaro/Projects/WebKit/Source/WebKit/UIProcess/API/glib/
> WebKitWebViewAccessible.h:24:10: fatal error: atk/atk.h: No such file or
> directory
>    24 | #include <atk/atk.h>
>       |          ^~~~~~~~~~~
> compilation terminated.
> 
> That's when building with -DUSE_GTK4=ON. WebKitWebViewAccessible still
> depends on AtkSocket. Maybe with GTK 3 the include dirs are inherited from
> GTK?

This made the build complete here, but I didn't test further than that:

  https://o.perezdecastro.org/9fh9za0w.diff

I'll look into submitting it as a proper patch later.
Comment 6 Adrian Perez 2022-03-24 04:40:09 PDT 
(In reply to Adrian Perez from comment #5)
> (In reply to Michael Catanzaro from comment #4)
> > I'm seeing a build failure:
> > 
> > In file included from
> > /home/mcatanzaro/Projects/WebKit/Source/WebKit/UIProcess/API/glib/
> > WebKitWebViewAccessible.cpp:21:
> > /home/mcatanzaro/Projects/WebKit/Source/WebKit/UIProcess/API/glib/
> > WebKitWebViewAccessible.h:24:10: fatal error: atk/atk.h: No such file or
> > directory
> >    24 | #include <atk/atk.h>
> >       |          ^~~~~~~~~~~
> > compilation terminated.
> > 
> > That's when building with -DUSE_GTK4=ON. WebKitWebViewAccessible still
> > depends on AtkSocket. Maybe with GTK 3 the include dirs are inherited from
> > GTK?
> 
> This made the build complete here, but I didn't test further than that:
> 
>   https://o.perezdecastro.org/9fh9za0w.diff
> 
> I'll look into submitting it as a proper patch later.

Here we go, bug #238320