Bug 238192 - [GPU Process] [GraphicsContextState 3/] Make GraphicsContextState a class
Summary: [GPU Process] [GraphicsContextState 3/] Make GraphicsContextState a class
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Said Abou-Hallawa
URL:
Keywords: InRadar
Depends on:
Blocks: 237728
  Show dependency treegraph
 
Reported: 2022-03-22 00:54 PDT by Said Abou-Hallawa
Modified: 2022-03-22 13:40 PDT (History)
6 users (show)

See Also:


Attachments
Patch (70.42 KB, patch)
2022-03-22 01:00 PDT, Said Abou-Hallawa
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (70.42 KB, patch)
2022-03-22 01:25 PDT, Said Abou-Hallawa
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (73.08 KB, patch)
2022-03-22 01:51 PDT, Said Abou-Hallawa
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (74.06 KB, patch)
2022-03-22 02:19 PDT, Said Abou-Hallawa
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (74.05 KB, patch)
2022-03-22 02:50 PDT, Said Abou-Hallawa
simon.fraser: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (75.17 KB, patch)
2022-03-22 10:59 PDT, Said Abou-Hallawa
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Said Abou-Hallawa 2022-03-22 00:54:32 PDT
This will make the members be private so we have to provide getters for all of them. This change will prevent changing the members without going through the setters.
Comment 1 Said Abou-Hallawa 2022-03-22 01:00:00 PDT
Created attachment 455344 [details]
Patch
Comment 2 Said Abou-Hallawa 2022-03-22 01:25:18 PDT
Created attachment 455346 [details]
Patch
Comment 3 Said Abou-Hallawa 2022-03-22 01:51:51 PDT
Created attachment 455349 [details]
Patch
Comment 4 Said Abou-Hallawa 2022-03-22 02:19:13 PDT
Created attachment 455353 [details]
Patch
Comment 5 Said Abou-Hallawa 2022-03-22 02:50:58 PDT
Created attachment 455356 [details]
Patch
Comment 6 Said Abou-Hallawa 2022-03-22 10:59:25 PDT
Created attachment 455395 [details]
Patch
Comment 7 EWS 2022-03-22 13:39:05 PDT
Committed r291696 (248738@main): <https://commits.webkit.org/248738@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 455395 [details].
Comment 8 Radar WebKit Bug Importer 2022-03-22 13:40:19 PDT
<rdar://problem/90656519>