Bug 238170 – Fetching a Blob URL with an unbounded Range header do not generate a Content-Range response header

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Jer Noble]

Fetching a Blob URL with an unbounded Range header do not generate a Content-Range response header

[Jer Noble]

Created attachment 455304 [details]
Patch

[Jean-Yves Avenard [:jya]]

Comment on attachment 455304 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=455304&action=review

> Source/WebKit/NetworkProcess/NetworkDataTaskBlob.cpp:279
> +        }

seems to be a lot of duplicated code around here.

[EWS]

Committed r291622 (248715@main): <https://commits.webkit.org/248715@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 455304 [details].

[Radar WebKit Bug Importer]

<rdar://problem/90637966>

[Darin Adler]

Comment on attachment 455304 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=455304&action=review

> Source/WebKit/NetworkProcess/NetworkDataTaskBlob.cpp:276
> +                rangeEnd = m_totalSize - 1;

Why is -1 correct?

[Jer Noble]

(In reply to Darin Adler from comment #5)
> Comment on attachment 455304 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=455304&action=review
> 
> > Source/WebKit/NetworkProcess/NetworkDataTaskBlob.cpp:276
> > +                rangeEnd = m_totalSize - 1;
> 
> Why is -1 correct?

Because a Content-Range header's "range end" is inclusive. (Which I agree is weird from a C++ POV.)

[Jer Noble]

*** Bug 238113 has been marked as a duplicate of this bug. ***