Bug 238169 – Add logging for LocalStorage and IndexedDB data migration

• Status: RESOLVED
• Resolution: FIXED
• Component: Website Storage

[Sihui Liu]

...

[Sihui Liu]

Created attachment 455303 [details]
Patch

[Chris Dumez]

Comment on attachment 455303 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=455303&action=review

> Source/WebCore/ChangeLog:3
> +        Add loggings for LocalStorage and IndexedDB data migration

loggings -> logging

> Source/WebCore/platform/sql/SQLiteFileSystem.cpp:98
> +        allMoved |= FileSystem::moveFile(makeString(oldFilePath, suffix), makeString(newFilePath, suffix));

This doesn't look right to me?

Shouldn't allMoved be initialized to false and the operator be &| here?

As it stands, I think this function will always return true.

[Sihui Liu]

Created attachment 455563 [details]
Patch

[Sihui Liu]

Comment on attachment 455303 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=455303&action=review

>> Source/WebCore/platform/sql/SQLiteFileSystem.cpp:98
>> +        allMoved |= FileSystem::moveFile(makeString(oldFilePath, suffix), makeString(newFilePath, suffix));
> 
> This doesn't look right to me?
> 
> Shouldn't allMoved be initialized to false and the operator be &| here?
> 
> As it stands, I think this function will always return true.

Yes, it should be &! Updated.

[Chris Dumez]

Comment on attachment 455563 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=455563&action=review

r=me

> Source/WebKit/NetworkProcess/storage/OriginStorageManager.cpp:358
> +            RELEASE_LOG(Storage, "%p - StorageBucket::resolvedLocalStoragePath New path '%s'", this, localStoragePath.utf8().data());

%{public}s if you want to see the path in public builds.

Given that the paths do not contain any origin information, I think it's OK.

> Source/WebKit/NetworkProcess/storage/OriginStorageManager.cpp:389
> +        RELEASE_LOG(Storage, "%p - StorageBucket::resolvedIDBStoragePath New path '%s'", this, idbStoragePath.utf8().data());

%{public}s

[Sihui Liu]

Created attachment 455603 [details]
Patch for landing

[EWS]

Committed r291786 (248814@main): <https://commits.webkit.org/248814@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 455603 [details].

[Radar WebKit Bug Importer]

<rdar://problem/90752697>