Bug 238155 – REGRESSION (r290794): [ iOS Debug ] 4 editing/selection/* tests are constant timeouts

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Dawn Morningstar]

editing/selection/move-by-word-visually-single-space-one-element.html
editing/selection/move-by-word-visually-single-space-inline-element.html
editing/selection/move-by-word-visually-multi-line.html
editing/selection/move-by-word-visually-mac.html

Are all constantly timing out on iOS Debug queues. 

HISTORY:
https://results.webkit.org/?suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&test=editing%2Fselection%2Fmove-by-word-visually-mac.html&test=editing%2Fselection%2Fmove-by-word-visually-multi-line.html&test=editing%2Fselection%2Fmove-by-word-visually-single-space-inline-element.html&test=editing%2Fselection%2Fmove-by-word-visually-single-space-one-element.html

DIFF is a 404 timeout.

Layout-Test-Results URL:
https://build.webkit.org/results/Apple-iOS-15-Simulator-Debug-WK2-Tests/r291558%20(2017)/results.html




editing/selection/move-by-word-visually-inline-block-positioned-element.html
Appears to be related with a similar regression range, though it is a flaky timeout.

[Radar WebKit Bug Importer]

<rdar://problem/90593957>

[Dawn Morningstar]

Suspected regression point: r290794 as this is the only revision that modifies iOS in range, but further testing is required to confirm.
([iOS] Further reduce hangs underneath)

[Wenson Hsieh]

(In reply to Matteo Flores from comment #2)
> Suspected regression point: r290794 as this is the only revision that
> modifies iOS in range, but further testing is required to confirm.
> ([iOS] Further reduce hangs underneath)

I think this makes sense, as a regression point.

That said, I think these tests should eventually finish (it just takes longer now). There might be some adjustments we can make to keep these tests within the time limit for non-fast layout tests, though — I'll take a look

[Dawn Morningstar]

(In reply to Wenson Hsieh from comment #3)
> (In reply to Matteo Flores from comment #2)
> > Suspected regression point: r290794 as this is the only revision that
> > modifies iOS in range, but further testing is required to confirm.
> > ([iOS] Further reduce hangs underneath)
> 
> I think this makes sense, as a regression point.
> 
> That said, I think these tests should eventually finish (it just takes
> longer now). There might be some adjustments we can make to keep these tests
> within the time limit for non-fast layout tests, though — I'll take a look

Perfect I also thought the same thing, that they just take longer now. There always is the option as marking these as [ Slow ].

[Wenson Hsieh]

(In reply to Matteo Flores from comment #4)
> (In reply to Wenson Hsieh from comment #3)
> > (In reply to Matteo Flores from comment #2)
> > > Suspected regression point: r290794 as this is the only revision that
> > > modifies iOS in range, but further testing is required to confirm.
> > > ([iOS] Further reduce hangs underneath)
> > 
> > I think this makes sense, as a regression point.
> > 
> > That said, I think these tests should eventually finish (it just takes
> > longer now). There might be some adjustments we can make to keep these tests
> > within the time limit for non-fast layout tests, though — I'll take a look
> 
> Perfect I also thought the same thing, that they just take longer now. There
> always is the option as marking these as [ Slow ].

Oh, good point. Perhaps we could try that first, and see if it mitigates these failures? (While I continue to investigate).

[Dawn Morningstar]

(In reply to Wenson Hsieh from comment #5)
> Oh, good point. Perhaps we could try that first, and see if it mitigates
> these failures? (While I continue to investigate).

Indeed I will do that right away.

[Dawn Morningstar]

r291584 Slow expectation has been set. Hopefully this will resolve the issue.

[Alexey Proskuryakov]

Looks like this helped three of them, but not editing/selection/move-by-word-visually-multi-line.html

[Wenson Hsieh]

Created attachment 455861 [details]
Patch

[Wenson Hsieh]

Created attachment 455862 [details]
Fix macOS build

[Wenson Hsieh]

Comment on attachment 455862 [details]
Fix macOS build

Thanks for the review!

[EWS]

Committed r292005 (248955@main): <https://commits.webkit.org/248955@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 455862 [details].

[Wenson Hsieh]

*** Bug 238479 has been marked as a duplicate of this bug. ***