RESOLVED FIXED 238148
Disable the <model> element in Captive Portal mode 
https://bugs.webkit.org/show_bug.cgi?id=238148
Summary Disable the <model> element in Captive Portal mode
Brent Fulgham
Reported 2022-03-21 11:29:18 PDT
When displaying content in a captive portal, we should make sure the experimental <model> element is unavailable.
Attachments
Patch (8.62 KB, patch)
2022-03-21 12:02 PDT, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Patch for landing (8.62 KB, patch)
2022-03-21 13:05 PDT, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Brent Fulgham
Comment 1 2022-03-21 11:29:31 PDT
<rdar://90562002>
Brent Fulgham
Comment 2 2022-03-21 12:02:11 PDT
Created attachment 455260 [details] Patch
Chris Dumez
Comment 3 2022-03-21 12:48:43 PDT
Comment on attachment 455260 [details] Patch r=me
Chris Dumez
Comment 4 2022-03-21 12:49:11 PDT
Comment on attachment 455260 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=455260&action=review > Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:7825 > + EXPECT_EQ(runJSCheck("!!window.HTMLModelElement"_s), shouldBeEnabled == ShouldBeEnabled::Yes); // Push API. The comment is wrong.
Brent Fulgham
Comment 5 2022-03-21 13:04:23 PDT
Comment on attachment 455260 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=455260&action=review >> Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:7825 >> + EXPECT_EQ(runJSCheck("!!window.HTMLModelElement"_s), shouldBeEnabled == ShouldBeEnabled::Yes); // Push API. > > The comment is wrong. Ugh! Thank you for catching that.
Brent Fulgham
Comment 6 2022-03-21 13:05:20 PDT
Created attachment 455267 [details] Patch for landing
EWS
Comment 7 2022-03-21 14:25:08 PDT
Committed r291579 (248679@main): <https://commits.webkit.org/248679@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 455267 [details].
Note You need to log in before you can comment on or make changes to this bug.