Bug 238141 - [TextureMapper] Split GraphicsContextGLTextureMapper into two classes
Summary: [TextureMapper] Split GraphicsContextGLTextureMapper into two classes
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
Keywords: InRadar
Depends on:
Blocks: DMA-BUF 238223
  Show dependency treegraph
Reported: 2022-03-21 07:11 PDT by Zan Dobersek
Modified: 2022-03-22 14:29 PDT (History)
12 users (show)

See Also:

Patch (27.26 KB, patch)
2022-03-21 07:20 PDT, Zan Dobersek
no flags Details | Formatted Diff | Diff
Patch for landing (26.81 KB, patch)
2022-03-21 23:57 PDT, Zan Dobersek
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2022-03-21 07:11:59 PDT
[TextureMapper] Split GraphicsContextGLTextureMapper into two classes
Comment 1 Zan Dobersek 2022-03-21 07:20:05 PDT
Created attachment 455244 [details]
Comment 2 Alejandro G. Castro 2022-03-21 13:25:40 PDT
Comment on attachment 455244 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=455244&action=review

LGTM! Check the option I pointed out to remove more code and the wincairo failure, I think it is not related but we want to make sure we do not break it.

> Source/WebCore/platform/graphics/texmap/GraphicsContextGLTextureMapperANGLE.cpp:123
> +    // Bail if GLES3 was requested but cannot be provided.
> +    if (attributes.webGLVersion == GraphicsContextGLWebGLVersion::WebGL2 && !epoxy_is_desktop_gl() && epoxy_gl_version() < 30)
> +        return nullptr;
> +#endif

I think we can remove this in the ANGLE case.
Comment 3 Zan Dobersek 2022-03-21 23:57:15 PDT
Created attachment 455339 [details]
Patch for landing
Comment 4 EWS 2022-03-22 03:05:13 PDT
Found 1 new test failure: imported/w3c/web-platform-tests/webstorage/event_case_sensitive.html
Comment 5 EWS 2022-03-22 03:19:33 PDT
Committed r291610 (248703@main): <https://commits.webkit.org/248703@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 455339 [details].
Comment 6 Radar WebKit Bug Importer 2022-03-22 03:20:16 PDT