WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
ASSIGNED
238115
Reduce size of CodeBlock and UnlinkedCodeBlock.
https://bugs.webkit.org/show_bug.cgi?id=238115
Summary
Reduce size of CodeBlock and UnlinkedCodeBlock.
Mark Lam
Reported
2022-03-19 12:50:42 PDT
Introduce a PackedFixedVector and PackedUniquePtr and use them in CodeBlock and UnlinkedCodeBlock. This reduces the size of the CodeBlock from 248 to 240 i.e. drops from 16 atoms (rounded up from 15.5) to 15 atoms. This reduces the size of the UnlinkedCodeBlock from 216 to 192 i.e. drops from 14 atoms (rounded up from 13.5) to 12 atoms.
Attachments
proposed patch.
(82.99 KB, patch)
2022-03-19 12:57 PDT
,
Mark Lam
ews-feeder
: commit-queue-
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Mark Lam
Comment 1
2022-03-19 12:57:54 PDT
Created
attachment 455170
[details]
proposed patch. Let's get some EWS testing.
Mark Lam
Comment 2
2022-03-23 17:57:36 PDT
The current proposal using Packed pointers appear to have a perf regression. Going to try using a ButterflyFixedVector instead (on Yusuke's suggestion).
Radar WebKit Bug Importer
Comment 3
2022-03-26 12:51:15 PDT
<
rdar://problem/90880721
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug