WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
238107
[IFC][Integration] Remove redundant InlineIterator::Line::contentLogicalTopAdjustedForHitTesting
https://bugs.webkit.org/show_bug.cgi?id=238107
Summary
[IFC][Integration] Remove redundant InlineIterator::Line::contentLogicalTopAd...
zalan
Reported
2022-03-18 21:20:20 PDT
ssia
Attachments
Patch
(7.77 KB, patch)
2022-03-18 21:28 PDT
,
zalan
no flags
Details
Formatted Diff
Diff
Patch
(10.94 KB, patch)
2022-03-19 22:12 PDT
,
zalan
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
zalan
Comment 1
2022-03-18 21:28:50 PDT
Created
attachment 455164
[details]
Patch
Antti Koivisto
Comment 2
2022-03-19 05:52:05 PDT
Comment on
attachment 455164
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=455164&action=review
> Source/WebCore/ChangeLog:9 > + - containingBlock's borer and padding before
border
> Source/WebCore/layout/integration/InlineIteratorLineModernPath.h:-61 > - float contentLogicalTopAdjustedForHitTesting() const { return !m_lineIndex ? containingBlock().borderAndPaddingBefore().toFloat() : contentLogicalTopAdjustedForPrecedingLine(); };
Did you forget to remove the LineLegacyPath version?
zalan
Comment 3
2022-03-19 22:12:02 PDT
Created
attachment 455188
[details]
Patch
EWS
Comment 4
2022-03-20 08:05:52 PDT
Committed
r291545
(
248651@main
): <
https://commits.webkit.org/248651@main
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 455188
[details]
.
Radar WebKit Bug Importer
Comment 5
2022-03-20 08:06:18 PDT
<
rdar://problem/90538811
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug