Bug 238102 – [cssom] border-image not serialized at specified-value time

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Oriol Brufau]

Run this:

    document.body.style.borderImage = 'url("") 10 / 20 / 30 round';
    
    document.body.style.borderImage;
    // Expected: 'url("") 10 / 20 / 30 round'
    // Actual: ''
    
    document.body.style.cssText;
    // Expected: 'border-image: url("") 10 / 20 / 30 round'
    // Actual: 'border-image-source: url(""); border-image-slice: 10; border-image-width: 20; border-image-outset: 30; border-image-repeat: round;'

[Oriol Brufau]

Created attachment 455147 [details]
Patch

[EWS Watchlist]

This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess

[Oriol Brufau]

Created attachment 455150 [details]
Patch

[Oriol Brufau]

PTAL

[Darin Adler]

Comment on attachment 455150 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=455150&action=review

> Source/WebCore/css/StyleProperties.cpp:952
> +            result.append(" / ");

It’s more efficient to append multiple strings in a single append call, less string buffer growing computation. So the separator could go into a local variable, and then:

    result.append(separator, valueText);

Just make sure to set separator to “” when one is not needed. In fact if we use a variable outside the loop, we can also avoid the result.isEmpty check.

    auto separator = “”;
    for … {
        …
        result.append(separator, valueText);
        separator = “ “;
    }

[Oriol Brufau]

Created attachment 455184 [details]
Patch

[EWS]

Committed r291537 (248643@main): <https://commits.webkit.org/248643@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 455184 [details].

[Radar WebKit Bug Importer]

<rdar://problem/90531782>

[Alexey Proskuryakov]

*** Bug 183993 has been marked as a duplicate of this bug. ***