Bug 238060 – Web Inspector: `console.screenshot` has extra transparent pixels at bottom of screenshot on platforms with viewports that are obscured by browser chrome

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Patrick Angle]

.

[Radar WebKit Bug Importer]

<rdar://problem/90460824>

[Patrick Angle]

Created attachment 455046 [details]
Screenshot of Issue

[Patrick Angle]

Created attachment 455049 [details]
Patch v1.0

[Patrick Angle]

Created attachment 455050 [details]
Screenshot of Patch v1.0

[Devin Rousso]

Comment on attachment 455049 [details]
Patch v1.0

View in context: https://bugs.webkit.org/attachment.cgi?id=455049&action=review

r=me, lol oops great catch

Any way to test this?

> Source/WebCore/page/PageConsoleClient.cpp:414
> +            IntRect imageRect(IntPoint::zero(), m_page.mainFrame().view()->unobscuredContentRect().size());

Do we care about the `location()` of the `unobscuredContentRect()`?  Should we maybe just use that as the `imageRect` instead of only taking it's `size()` with `IntPoint::zero()` as the `location`?

[Patrick Angle]

Comment on attachment 455049 [details]
Patch v1.0

View in context: https://bugs.webkit.org/attachment.cgi?id=455049&action=review

>> Source/WebCore/page/PageConsoleClient.cpp:414
>> +            IntRect imageRect(IntPoint::zero(), m_page.mainFrame().view()->unobscuredContentRect().size());
> 
> Do we care about the `location()` of the `unobscuredContentRect()`?  Should we maybe just use that as the `imageRect` instead of only taking it's `size()` with `IntPoint::zero()` as the `location`?

The implementation of `unobscuredContentRect()` sets the `location()` to the current scroll position, which we don't want... although I guess we could stop passing `SnapshotFlags::InViewCoordinates` into `snapshotFrameRect` below and that would work (I think).

[Patrick Angle]

Created attachment 455128 [details]
Patch v1.1

[EWS]

Committed r291519 (248625@main): <https://commits.webkit.org/248625@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 455128 [details].