Bug 238058 - libANGLE-shared.dylib, libwebrtc.dylib & WebGPU install names are prefixed with the system content path
Summary: libANGLE-shared.dylib, libwebrtc.dylib & WebGPU install names are prefixed wi...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Michael Saboff
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-03-17 16:51 PDT by Michael Saboff
Modified: 2022-03-17 17:46 PDT (History)
8 users (show)

See Also:

Attachments
Patch (5.38 KB, patch)
2022-03-17 17:08 PDT, Michael Saboff 		no flags Details | Formatted Diff | Diff
Updated Patch (5.35 KB, patch)
2022-03-17 17:27 PDT, Michael Saboff 		mark.lam: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Saboff 2022-03-17 16:51:47 PDT 
The install names for these dylibs should not include the system content path prefix.
Comment 1 Michael Saboff 2022-03-17 16:51:59 PDT 
<rdar://90449608>
Comment 2 Michael Saboff 2022-03-17 17:08:08 PDT 
Created attachment 455048 [details]
Patch
Comment 3 EWS Watchlist 2022-03-17 17:10:26 PDT 
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE
Comment 4 David Quesada 2022-03-17 17:16:52 PDT 
Comment on attachment 455048 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=455048&action=review

> Source/ThirdParty/ANGLE/Configurations/ANGLE-dynamic.xcconfig:33
> +DYLIB_INSTALL_NAME_BASE = $(NORMAL_WEBCORE_FRAMEWORKS_DIR)/WebCore.framework/Versions/A/Frameworks;

I don't think this is a correct default for iOS builds -- it should be `$(NORMAL_WEBCORE_FRAMEWORKS_DIR)/WebCore.framework/Frameworks` since iOS doesn't use `Versions/A`

> Source/ThirdParty/libwebrtc/Configurations/libwebrtc.xcconfig:48
> +DYLIB_INSTALL_NAME_BASE = $(NORMAL_WEBCORE_FRAMEWORKS_DIR)/WebCore.framework/Versions/A/Frameworks;

Ditto.
Comment 5 Michael Saboff 2022-03-17 17:22:41 PDT 
(In reply to David Quesada from comment #4)
> Comment on attachment 455048 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=455048&action=review
> 
> > Source/ThirdParty/ANGLE/Configurations/ANGLE-dynamic.xcconfig:33
> > +DYLIB_INSTALL_NAME_BASE = $(NORMAL_WEBCORE_FRAMEWORKS_DIR)/WebCore.framework/Versions/A/Frameworks;
> 
> I don't think this is a correct default for iOS builds -- it should be
> `$(NORMAL_WEBCORE_FRAMEWORKS_DIR)/WebCore.framework/Frameworks` since iOS
> doesn't use `Versions/A`
> 
> > Source/ThirdParty/libwebrtc/Configurations/libwebrtc.xcconfig:48
> > +DYLIB_INSTALL_NAME_BASE = $(NORMAL_WEBCORE_FRAMEWORKS_DIR)/WebCore.framework/Versions/A/Frameworks;
> 
> Ditto.

I'll update those and post a new patch.
Comment 6 Michael Saboff 2022-03-17 17:27:15 PDT 
Created attachment 455052 [details]
Updated Patch
Comment 7 Mark Lam 2022-03-17 17:30:26 PDT 
Comment on attachment 455052 [details]
Updated Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=455052&action=review

r=me

> Source/ThirdParty/ANGLE/ChangeLog:3
> +        libANGLE-shared.dylib, Ælibwebrtc.dylib & WebGPU install names are prefixed with the system content path

Can you fix non-ASCII chars here?

> Source/ThirdParty/libwebrtc/ChangeLog:3
> +        libANGLE-shared.dylib, Ælibwebrtc.dylib & WebGPU install names are prefixed with the system content path

Ditto.

> Source/WebGPU/ChangeLog:3
> +        libANGLE-shared.dylib, Ælibwebrtc.dylib & WebGPU install names are prefixed with the system content path

Ditto.
Comment 8 Michael Saboff 2022-03-17 17:34:15 PDT 
(In reply to Mark Lam from comment #7)
> Comment on attachment 455052 [details]
> Updated Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=455052&action=review
> 
> r=me
> 
> > Source/ThirdParty/ANGLE/ChangeLog:3
> > +        libANGLE-shared.dylib, Ælibwebrtc.dylib & WebGPU install names are prefixed with the system content path
> 
> Can you fix non-ASCII chars here?
> 
> > Source/ThirdParty/libwebrtc/ChangeLog:3
> > +        libANGLE-shared.dylib, Ælibwebrtc.dylib & WebGPU install names are prefixed with the system content path
> 
> Ditto.
> 
> > Source/WebGPU/ChangeLog:3
> > +        libANGLE-shared.dylib, Ælibwebrtc.dylib & WebGPU install names are prefixed with the system content path
> 
> Ditto.

Weird.  Must of got there when I copied from the radar.  These characters have been removed.
Comment 9 Michael Saboff 2022-03-17 17:46:21 PDT 
Committed r291455 (248577@trunk): <https://commits.webkit.org/248577@trunk>