Bug 238058 – libANGLE-shared.dylib, libwebrtc.dylib & WebGPU install names are prefixed with the system content path

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Michael Saboff]

The install names for these dylibs should not include the system content path prefix.

[Michael Saboff]

<rdar://90449608>

[Michael Saboff]

Created attachment 455048 [details]
Patch

[EWS Watchlist]

Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE

[David Quesada]

Comment on attachment 455048 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=455048&action=review

> Source/ThirdParty/ANGLE/Configurations/ANGLE-dynamic.xcconfig:33
> +DYLIB_INSTALL_NAME_BASE = $(NORMAL_WEBCORE_FRAMEWORKS_DIR)/WebCore.framework/Versions/A/Frameworks;

I don't think this is a correct default for iOS builds -- it should be `$(NORMAL_WEBCORE_FRAMEWORKS_DIR)/WebCore.framework/Frameworks` since iOS doesn't use `Versions/A`

> Source/ThirdParty/libwebrtc/Configurations/libwebrtc.xcconfig:48
> +DYLIB_INSTALL_NAME_BASE = $(NORMAL_WEBCORE_FRAMEWORKS_DIR)/WebCore.framework/Versions/A/Frameworks;

Ditto.

[Michael Saboff]

(In reply to David Quesada from comment #4)
> Comment on attachment 455048 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=455048&action=review
> 
> > Source/ThirdParty/ANGLE/Configurations/ANGLE-dynamic.xcconfig:33
> > +DYLIB_INSTALL_NAME_BASE = $(NORMAL_WEBCORE_FRAMEWORKS_DIR)/WebCore.framework/Versions/A/Frameworks;
> 
> I don't think this is a correct default for iOS builds -- it should be
> `$(NORMAL_WEBCORE_FRAMEWORKS_DIR)/WebCore.framework/Frameworks` since iOS
> doesn't use `Versions/A`
> 
> > Source/ThirdParty/libwebrtc/Configurations/libwebrtc.xcconfig:48
> > +DYLIB_INSTALL_NAME_BASE = $(NORMAL_WEBCORE_FRAMEWORKS_DIR)/WebCore.framework/Versions/A/Frameworks;
> 
> Ditto.

I'll update those and post a new patch.

[Michael Saboff]

Created attachment 455052 [details]
Updated Patch

[Mark Lam]

Comment on attachment 455052 [details]
Updated Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=455052&action=review

r=me

> Source/ThirdParty/ANGLE/ChangeLog:3
> +        libANGLE-shared.dylib, Ælibwebrtc.dylib & WebGPU install names are prefixed with the system content path

Can you fix non-ASCII chars here?

> Source/ThirdParty/libwebrtc/ChangeLog:3
> +        libANGLE-shared.dylib, Ælibwebrtc.dylib & WebGPU install names are prefixed with the system content path

Ditto.

> Source/WebGPU/ChangeLog:3
> +        libANGLE-shared.dylib, Ælibwebrtc.dylib & WebGPU install names are prefixed with the system content path

Ditto.

[Michael Saboff]

(In reply to Mark Lam from comment #7)
> Comment on attachment 455052 [details]
> Updated Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=455052&action=review
> 
> r=me
> 
> > Source/ThirdParty/ANGLE/ChangeLog:3
> > +        libANGLE-shared.dylib, Ælibwebrtc.dylib & WebGPU install names are prefixed with the system content path
> 
> Can you fix non-ASCII chars here?
> 
> > Source/ThirdParty/libwebrtc/ChangeLog:3
> > +        libANGLE-shared.dylib, Ælibwebrtc.dylib & WebGPU install names are prefixed with the system content path
> 
> Ditto.
> 
> > Source/WebGPU/ChangeLog:3
> > +        libANGLE-shared.dylib, Ælibwebrtc.dylib & WebGPU install names are prefixed with the system content path
> 
> Ditto.

Weird.  Must of got there when I copied from the radar.  These characters have been removed.

[Michael Saboff]

Committed r291455 (248577@trunk): <https://commits.webkit.org/248577@trunk>