Bug 23803 - fix 'off-by-1' error in Chromium font fallback
Summary: fix 'off-by-1' error in Chromium font fallback
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows XP
: P2 Minor
Assignee: Jungshik Shin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-02-06 15:38 PST by Jungshik Shin
Modified: 2009-03-03 10:22 PST (History)
2 users (show)

See Also:


Attachments
a test case (271 bytes, text/html)
2009-02-06 15:39 PST, Jungshik Shin
no flags Details
1-liner patch (with a comment) (1.56 KB, patch)
2009-02-06 15:56 PST, Jungshik Shin
eric: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jungshik Shin 2009-02-06 15:38:58 PST
There's an 'off-by-1' error in platform/graphics/chromium/FontCacheChromium.cpp. 
As a result, when only the last font in the list of fallback fonts covers a character, the character is regarded as not covered by any font and is rendered as an empty box.
Comment 1 Jungshik Shin 2009-02-06 15:39:49 PST
Created attachment 27426 [details]
a test case

With code2000 font installed, all 3 lines should be rendered identically.
Comment 2 Jungshik Shin 2009-02-06 15:56:06 PST
Created attachment 27429 [details]
1-liner patch (with a comment)
Comment 3 Eric Seidel (no email) 2009-02-24 16:05:27 PST
Comment on attachment 27429 [details]
1-liner patch (with a comment)

OK.  In the future, you don't need to make me the requestee.  WebKit doesn't tend to target reviews to specific people unless you know that they are the only person who could review your change.  In this case, I'm not the only person who could review this change.  Making me the requestee is likely to just slow down the process.
Comment 4 Dimitri Glazkov (Google) 2009-03-03 10:22:30 PST
Landed as http://trac.webkit.org/changeset/41392.