Bug 238028 – [GStreamer] Add stop position to the range request

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Enrique Ocaña]

Currently, the range requests performed by WebKitWebSourceGStreamer indicate a range start position but not a range stop one, even though it's set in the internal members->stopPosition attribute.

[Enrique Ocaña]

Created attachment 454997 [details]
Patch

[Philippe Normand]

Comment on attachment 454997 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454997&action=review

> Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:680
> +            formatedRange.reset(g_strdup_printf("bytes=%" G_GUINT64_FORMAT "-%" G_GUINT64_FORMAT, members->requestedPosition, (members->stopPosition > 0) ? members->stopPosition - 1 : 0));

The wrapping parentheses are not needed.

[Adam Podolnick]

Is this a regression of this: https://bugs.webkit.org/show_bug.cgi?id=236401 ?

We have a customer that's having an issue playing videos within an embedded WebView in FileMaker Pro on macOS 12.3. While this bug appears to have been fixed in Safari proper, it looks like it's still broken in embedded WebViews.

If this isn't related, let me know and I'll file a new bug.

[Philippe Normand]

The GStreamer backend is not used by the mac ports, so I doubt this patch will solve your issues.

[Enrique Ocaña]

Created attachment 455090 [details]
Patch

[EWS]

Found 2 new test failures: imported/w3c/web-platform-tests/workers/interfaces/WorkerUtils/importScripts/report-error-setTimeout-cross-origin.sub.any.worker.html, imported/w3c/web-platform-tests/workers/interfaces/WorkerUtils/importScripts/report-error-setTimeout-redirect-to-cross-origin.sub.any.worker.html

[EWS]

Committed r291487 (248601@main): <https://commits.webkit.org/248601@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 455090 [details].

[Radar WebKit Bug Importer]

<rdar://problem/90490318>