Bug 238024 - Recycling a webgl context when it has been lost and restored causes a crash
Summary: Recycling a webgl context when it has been lost and restored causes a crash
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kimmo Kinnunen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-03-17 07:40 PDT by Kimmo Kinnunen
Modified: 2022-05-25 14:52 PDT (History)
12 users (show)

See Also:

Attachments
wip (27.37 KB, patch)
2022-03-17 07:43 PDT, Kimmo Kinnunen 		no flags Details | Formatted Diff | Diff
Patch (33.14 KB, patch)
2022-03-17 12:06 PDT, Kimmo Kinnunen 		no flags Details | Formatted Diff | Diff
Patch for landing (33.94 KB, patch)
2022-03-18 00:50 PDT, Kimmo Kinnunen 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kimmo Kinnunen 2022-03-17 07:40:02 PDT 
Recycling a webgl context when it has been lost and restored causes a crash

lose a context
schedule it for restore
force the context lost due to "recycling", e.g. exceeding active context limit
Comment 1 Kimmo Kinnunen 2022-03-17 07:43:36 PDT 
Created attachment 454973 [details]
wip
Comment 2 Kimmo Kinnunen 2022-03-17 12:06:05 PDT 
Created attachment 455000 [details]
Patch
Comment 3 Geoffrey Garen 2022-03-17 12:18:12 PDT 
Comment on attachment 455000 [details]
Patch

r=me

All red! I feel bad for taking away the ability to r+ this patch from Alex Christensen.
Comment 4 Kimmo Kinnunen 2022-03-18 00:50:37 PDT 
Created attachment 455074 [details]
Patch for landing
Comment 5 EWS 2022-03-18 05:19:10 PDT 
Committed r291477 (248593@main): <https://commits.webkit.org/248593@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 455074 [details].
Comment 6 Radar WebKit Bug Importer 2022-03-18 05:20:18 PDT 
<rdar://problem/90481699>