Bug 238020 - [GTK][WPE] m_compositorThread ASSERT in TextureMapper classes can just be used in debug mode
Summary: [GTK][WPE] m_compositorThread ASSERT in TextureMapper classes can just be use...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alejandro G. Castro
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-03-17 06:39 PDT by Alejandro G. Castro
Modified: 2022-03-17 14:22 PDT (History)
7 users (show)

See Also:


Attachments
Patch (5.03 KB, patch)
2022-03-17 06:49 PDT, Alejandro G. Castro
no flags Details | Formatted Diff | Diff
Patch for landing (5.03 KB, patch)
2022-03-17 13:01 PDT, Alejandro G. Castro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alejandro G. Castro 2022-03-17 06:39:23 PDT
The m_compositorThread attribute is just defined in debug we can not use it outside in case someone compiles with assertions and debug build, Michael pointed it out in the bug #237948
Comment 1 Alejandro G. Castro 2022-03-17 06:49:52 PDT
Created attachment 454966 [details]
Patch
Comment 2 Michael Catanzaro 2022-03-17 07:20:29 PDT
Comment on attachment 454966 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454966&action=review

> Source/WebCore/platform/graphics/texmap/TextureMapperPlatformLayerProxyGL.cpp:92
>      ASSERT(m_compositorThread == &Thread::current());
> +#if ASSERT_ENABLED
> +        m_compositorThread = nullptr;
> +#endif

Indentation is off here
Comment 3 Alejandro G. Castro 2022-03-17 12:56:25 PDT
(In reply to Michael Catanzaro from comment #2)
> Comment on attachment 454966 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=454966&action=review
> 
> > Source/WebCore/platform/graphics/texmap/TextureMapperPlatformLayerProxyGL.cpp:92
> >      ASSERT(m_compositorThread == &Thread::current());
> > +#if ASSERT_ENABLED
> > +        m_compositorThread = nullptr;
> > +#endif
> 
> Indentation is off here

Right! Thanks for the review Michael.
Comment 4 Alejandro G. Castro 2022-03-17 13:01:01 PDT
Created attachment 455007 [details]
Patch for landing
Comment 5 EWS 2022-03-17 14:22:34 PDT
Committed r291442 (248566@main): <https://commits.webkit.org/248566@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 455007 [details].