Bug 238020 – [GTK][WPE] m_compositorThread ASSERT in TextureMapper classes can just be used in debug mode

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Alejandro G. Castro]

The m_compositorThread attribute is just defined in debug we can not use it outside in case someone compiles with assertions and debug build, Michael pointed it out in the bug #237948

[Alejandro G. Castro]

Created attachment 454966 [details]
Patch

[Michael Catanzaro]

Comment on attachment 454966 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454966&action=review

> Source/WebCore/platform/graphics/texmap/TextureMapperPlatformLayerProxyGL.cpp:92
>      ASSERT(m_compositorThread == &Thread::current());
> +#if ASSERT_ENABLED
> +        m_compositorThread = nullptr;
> +#endif

Indentation is off here

[Alejandro G. Castro]

(In reply to Michael Catanzaro from comment #2)
> Comment on attachment 454966 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=454966&action=review
> 
> > Source/WebCore/platform/graphics/texmap/TextureMapperPlatformLayerProxyGL.cpp:92
> >      ASSERT(m_compositorThread == &Thread::current());
> > +#if ASSERT_ENABLED
> > +        m_compositorThread = nullptr;
> > +#endif
> 
> Indentation is off here

Right! Thanks for the review Michael.

[Alejandro G. Castro]

Created attachment 455007 [details]
Patch for landing

[EWS]

Committed r291442 (248566@main): <https://commits.webkit.org/248566@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 455007 [details].