Bug 238010 – Build broken on macOS Monterey 12.3 - PassKitSPI related error

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Nikolas Zimmermann]

The Xcode build is broken: PushSubscriptionIdentifier.h is present twice in the Xcode project file, and the "copy phase" fails due to that.

[Nikolas Zimmermann]

Committed r291394 (248524@trunk): <https://commits.webkit.org/248524@trunk>

[Nikolas Zimmermann]

Reopening to attach new patch.

[Nikolas Zimmermann]

Created attachment 454940 [details]
Patch, v1

[Nikolas Zimmermann]

(In reply to Nikolas Zimmermann from comment #2)
> Reopening to attach new patch.

Nah, just for reference I wanted to have the patch here as well.

[Radar WebKit Bug Importer]

<rdar://problem/90417687>

[Nikolas Zimmermann]

For reference: this was a side problem due to a Xcode setting and is not the real build issue: PassKitSPI.h:309 refers to an unknown type 'PKShippingMethod' on macOS Monterey 12.3 -- upgraded yesterday and can't build WebKit since then:


In file included from /Users/nzimmermann/Software/GitRepositories/WebKitVanilla/Source/WebCore/PAL/pal/cocoa/PassKitSoftLink.mm:30:
/Users/nzimmermann/Software/GitRepositories/WebKitVanilla/Source/WebCore/PAL/pal/spi/cocoa/PassKitSPI.h:309:42: error: unknown type name 'PKShippingMethod'; did you mean
      'PKShippingMethods'?
- (instancetype)initWithMethods:(NSArray<PKShippingMethod *> *)methods defaultMethod:(nullable PKShippingMethod *)defaultMethod;
                                         ^~~~~~~~~~~~~~~~
                                         PKShippingMethods
/Users/nzimmermann/Software/GitRepositories/WebKitVanilla/Source/WebCore/PAL/pal/spi/cocoa/PassKitSPI.h:308:12: note: 'PKShippingMethods' declared here
@interface PKShippingMethods : NSObject
           ^
/Users/nzimmermann/Software/GitRepositories/WebKitVanilla/Source/WebCore/PAL/pal/spi/cocoa/PassKitSPI.h:309:96: error: expected a type
- (instancetype)initWithMethods:(NSArray<PKShippingMethod *> *)methods defaultMethod:(nullable PKShippingMethod *)defaultMethod;
                                                                                               ^

2 errors generated.

[Nikolas Zimmermann]

Hmm, if the APPLE_INTERNAL_SDK is not used, then PassKitSPI.h just includes PassKit.h on iOS and for PLATFORM(MAC) it actually contains the definitions of e.g. PKAddressField, ... and also PKShippingMethod.

But PKShippingMethod interface is declared after the first usage -- that's causing the build error -- will prepare a fix.

[Nikolas Zimmermann]

Created attachment 454952 [details]
Patch, v1

[Nikolas Zimmermann]

Created attachment 454961 [details]
Patch, v2

[Nikolas Zimmermann]

Tried to from-scratch release / debug builds -- now works flawlessly on macOS 12.3.

[Nikolas Zimmermann]

Committed r291403 (248533@trunk): <https://commits.webkit.org/248533@trunk>

[Ryan Haddad]

*** Bug 237991 has been marked as a duplicate of this bug. ***