Bug 237986 – Don't build WebPageProxy::writePromisedAttachmentToPasteboard() and its IPC on macOS

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Chris Dumez]

Don't build WebPageProxy::writePromisedAttachmentToPasteboard() and its IPC on macOS since it is only useful on iOS.

[Chris Dumez]

Created attachment 454903 [details]
Patch

[Brent Fulgham]

Comment on attachment 454903 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454903&action=review

> Source/WebKit/UIProcess/WebPageProxy.cpp:10196
> +#if PLATFORM(IOS_FAMILY)

It seems like this message is only ever used on iOS/iPadOS (_writePromisedAttachmentToPasteboard is a no-op on watchOS/tvOS), so it might be possible to remove the message entirely on tvOS/watchOS (though perhaps not worth doing).

[Brent Fulgham]

Comment on attachment 454903 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454903&action=review

> Source/WebKit/UIProcess/WebPageProxy.h:2546
>      void writePromisedAttachmentToPasteboard(WebCore::PromisedAttachmentInfo&&, const String& authorizationToken);

You could probably make this change to "PageClient" as well, so it would avoid compiling another virtual method on macOS.

[Chris Dumez]

(In reply to Brent Fulgham from comment #2)
> Comment on attachment 454903 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=454903&action=review
> 
> > Source/WebKit/UIProcess/WebPageProxy.cpp:10196
> > +#if PLATFORM(IOS_FAMILY)
> 
> It seems like this message is only ever used on iOS/iPadOS
> (_writePromisedAttachmentToPasteboard is a no-op on watchOS/tvOS), so it
> might be possible to remove the message entirely on tvOS/watchOS (though
> perhaps not worth doing).

Based on the IPC sender, the condition is PLATFORM(IOS_FAMILY) && ENABLE(ATTACHMENT_ELEMENT). It matches what I have here on recipient side.

[Chris Dumez]

Created attachment 454904 [details]
Patch

[Chris Dumez]

(In reply to Brent Fulgham from comment #3)
> Comment on attachment 454903 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=454903&action=review
> 
> > Source/WebKit/UIProcess/WebPageProxy.h:2546
> >      void writePromisedAttachmentToPasteboard(WebCore::PromisedAttachmentInfo&&, const String& authorizationToken);
> 
> You could probably make this change to "PageClient" as well, so it would
> avoid compiling another virtual method on macOS.

Good idea, done.

[Brent Fulgham]

Comment on attachment 454904 [details]
Patch

r=me

[EWS]

Committed r291381 (248512@main): <https://commits.webkit.org/248512@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 454904 [details].

[Radar WebKit Bug Importer]

<rdar://problem/90402469>