Bug 237978 - [Cocoa] Minor AVVideoCaptureSource cleanup
Summary: [Cocoa] Minor AVVideoCaptureSource cleanup
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-03-16 13:13 PDT by Eric Carlson
Modified: 2022-03-16 16:02 PDT (History)
10 users (show)

See Also:

Attachments
Patch (2.19 KB, patch)
2022-03-16 13:22 PDT, Eric Carlson 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2022-03-16 13:13:26 PDT 
Minor AVVideoCaptureSource cleanup
Comment 1 Radar WebKit Bug Importer 2022-03-16 13:13:36 PDT 
<rdar://problem/90388332>
Comment 2 Eric Carlson 2022-03-16 13:22:09 PDT 
Created attachment 454887 [details]
Patch
Comment 3 Peng Liu 2022-03-16 13:53:06 PDT 
Comment on attachment 454887 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454887&action=review

> Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm:429
> +        m_session = adoptNS([PAL::allocAVCaptureSessionInstance() init]);

Looks like this change is not intended?
Comment 4 Eric Carlson 2022-03-16 14:03:34 PDT 
Comment on attachment 454887 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454887&action=review

>> Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm:429
>> +        m_session = adoptNS([PAL::allocAVCaptureSessionInstance() init]);
> 
> Looks like this change is not intended?

It is, it is needed to line up with the `else` above the `#else`.
Comment 5 EWS 2022-03-16 16:02:20 PDT 
Committed r291374 (248506@main): <https://commits.webkit.org/248506@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 454887 [details].