RESOLVED FIXED 237978
[Cocoa] Minor AVVideoCaptureSource cleanup 
https://bugs.webkit.org/show_bug.cgi?id=237978
Summary [Cocoa] Minor AVVideoCaptureSource cleanup
Eric Carlson
Reported 2022-03-16 13:13:26 PDT
Minor AVVideoCaptureSource cleanup
Attachments
Patch (2.19 KB, patch)
2022-03-16 13:22 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2022-03-16 13:13:36 PDT
<rdar://problem/90388332>
Eric Carlson
Comment 2 2022-03-16 13:22:09 PDT
Created attachment 454887 [details] Patch
Peng Liu
Comment 3 2022-03-16 13:53:06 PDT
Comment on attachment 454887 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=454887&action=review > Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm:429 > + m_session = adoptNS([PAL::allocAVCaptureSessionInstance() init]); Looks like this change is not intended?
Eric Carlson
Comment 4 2022-03-16 14:03:34 PDT
Comment on attachment 454887 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=454887&action=review >> Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm:429 >> + m_session = adoptNS([PAL::allocAVCaptureSessionInstance() init]); > > Looks like this change is not intended? It is, it is needed to line up with the `else` above the `#else`.
EWS
Comment 5 2022-03-16 16:02:20 PDT
Committed r291374 (248506@main): <https://commits.webkit.org/248506@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 454887 [details].
Note You need to log in before you can comment on or make changes to this bug.