Bug 237975 - Fix for accessibility/aria-option-role.html in isolated tree mode.
Summary: Fix for accessibility/aria-option-role.html in isolated tree mode.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andres Gonzalez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-03-16 12:41 PDT by Andres Gonzalez
Modified: 2022-03-17 07:23 PDT (History)
10 users (show)

See Also:

Attachments
Patch (4.48 KB, patch)
2022-03-16 12:46 PDT, Andres Gonzalez 		no flags Details | Formatted Diff | Diff
Patch (4.51 KB, patch)
2022-03-16 13:10 PDT, Andres Gonzalez 		no flags Details | Formatted Diff | Diff
Patch (6.54 KB, patch)
2022-03-16 16:33 PDT, Andres Gonzalez 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andres Gonzalez 2022-03-16 12:41:19 PDT 
Fix for accessibility/aria-option-role.html in isolated tree mode.
Comment 1 Radar WebKit Bug Importer 2022-03-16 12:41:29 PDT 
<rdar://problem/90386629>
Comment 2 Andres Gonzalez 2022-03-16 12:46:34 PDT 
Created attachment 454882 [details]
Patch
Comment 3 chris fleizach 2022-03-16 12:57:24 PDT 
Comment on attachment 454882 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454882&action=review

> LayoutTests/platform/mac/accessibility/aria-option-role-expected.txt:-8
> -firstChild.role is AXRole: AXStaticText

we're no longer outputting the role value for these objects. I think we should make sure they're there
Comment 4 Andres Gonzalez 2022-03-16 13:10:45 PDT 
Created attachment 454885 [details]
Patch
Comment 5 Andres Gonzalez 2022-03-16 13:13:29 PDT 
(In reply to chris fleizach from comment #3)
> Comment on attachment 454882 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=454882&action=review
> 
> > LayoutTests/platform/mac/accessibility/aria-option-role-expected.txt:-8
> > -firstChild.role is AXRole: AXStaticText
> 
> we're no longer outputting the role value for these objects. I think we
> should make sure they're there

Of course, missed the debug(output) after building the output string. Thanks for caching.
Comment 6 Andres Gonzalez 2022-03-16 16:33:58 PDT 
Created attachment 454910 [details]
Patch

fix for glib and win expectations.
Comment 7 EWS 2022-03-17 05:02:31 PDT 
Committed r291400 (248530@main): <https://commits.webkit.org/248530@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 454910 [details].