RESOLVED FIXED 237975
Fix for accessibility/aria-option-role.html in isolated tree mode. 
https://bugs.webkit.org/show_bug.cgi?id=237975
Summary Fix for accessibility/aria-option-role.html in isolated tree mode.
Andres Gonzalez
Reported 2022-03-16 12:41:19 PDT
Fix for accessibility/aria-option-role.html in isolated tree mode.
Attachments
Patch (4.48 KB, patch)
2022-03-16 12:46 PDT, Andres Gonzalez 		no flags
DetailsFormatted DiffDiff
Patch (4.51 KB, patch)
2022-03-16 13:10 PDT, Andres Gonzalez 		no flags
DetailsFormatted DiffDiff
Patch (6.54 KB, patch)
2022-03-16 16:33 PDT, Andres Gonzalez 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2022-03-16 12:41:29 PDT
<rdar://problem/90386629>
Andres Gonzalez
Comment 2 2022-03-16 12:46:34 PDT
Created attachment 454882 [details] Patch
chris fleizach
Comment 3 2022-03-16 12:57:24 PDT
Comment on attachment 454882 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=454882&action=review > LayoutTests/platform/mac/accessibility/aria-option-role-expected.txt:-8 > -firstChild.role is AXRole: AXStaticText we're no longer outputting the role value for these objects. I think we should make sure they're there
Andres Gonzalez
Comment 4 2022-03-16 13:10:45 PDT
Created attachment 454885 [details] Patch
Andres Gonzalez
Comment 5 2022-03-16 13:13:29 PDT
(In reply to chris fleizach from comment #3) > Comment on attachment 454882 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=454882&action=review > > > LayoutTests/platform/mac/accessibility/aria-option-role-expected.txt:-8 > > -firstChild.role is AXRole: AXStaticText > > we're no longer outputting the role value for these objects. I think we > should make sure they're there Of course, missed the debug(output) after building the output string. Thanks for caching.
Andres Gonzalez
Comment 6 2022-03-16 16:33:58 PDT
Created attachment 454910 [details] Patch fix for glib and win expectations.
EWS
Comment 7 2022-03-17 05:02:31 PDT
Committed r291400 (248530@main): <https://commits.webkit.org/248530@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 454910 [details].
Note You need to log in before you can comment on or make changes to this bug.