Bug 237966 – [iOS] WebAVMediaSelectionOption should implement -mediaType

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Eric Carlson]

WebAVMediaSelectionOption should implement -mediaType

[Eric Carlson]

rdar://89934589

[Eric Carlson]

Created attachment 454849 [details]
Patch

[Jer Noble]

Comment on attachment 454849 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454849&action=review

> Source/WebCore/platform/MediaSelectionOption.h:87
> +template<class Decoder> std::optional<MediaSelectionOption> MediaSelectionOption::decode(Decoder& decoder)
> +{
> +    MediaSelectionOption option;
> +
> +    if (!decoder.decode(option.mediaType))
> +        return { };
> +
> +    if (!decoder.decode(option.displayName))
> +        return { };
> +
> +    if (!decoder.decode(option.legibleType))
> +        return { };
> +
> +    return option;
> +}

Nit: this could be:

template<class Decoder> bool MediaSelectionOption::decode(Decoder& decoder, MediaSelectionOption& option)
{
    return decoder.decode(option.mediaType)
        && decoder.decode(option.displayName)
        && decoder.decode(option.legibleType);
}

Slightly more compact. No hard evidence if this is true or not, but my intuition says it's slightly more efficient as well.

[Eric Carlson]

Created attachment 454852 [details]
Patch for landing

[EWS]

Committed r291361 (248493@main): <https://commits.webkit.org/248493@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 454852 [details].