WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
237963
Pass style builder context to CSSToLengthConversionData
https://bugs.webkit.org/show_bug.cgi?id=237963
Summary
Pass style builder context to CSSToLengthConversionData
Antti Koivisto
Reported
2022-03-16 08:59:05 PDT
Preparation for resolving container units.
Attachments
Patch
(17.59 KB, patch)
2022-03-16 09:30 PDT
,
Antti Koivisto
no flags
Details
Formatted Diff
Diff
Patch
(21.52 KB, patch)
2022-03-16 10:36 PDT
,
Antti Koivisto
ews-feeder
: commit-queue-
Details
Formatted Diff
Diff
Patch
(21.49 KB, patch)
2022-03-16 10:45 PDT
,
Antti Koivisto
no flags
Details
Formatted Diff
Diff
Patch
(22.98 KB, patch)
2022-03-16 11:56 PDT
,
Antti Koivisto
no flags
Details
Formatted Diff
Diff
Patch
(22.97 KB, patch)
2022-03-16 12:00 PDT
,
Antti Koivisto
no flags
Details
Formatted Diff
Diff
Patch
(22.46 KB, patch)
2022-03-16 13:13 PDT
,
Antti Koivisto
no flags
Details
Formatted Diff
Diff
Show Obsolete
(5)
View All
Add attachment
proposed patch, testcase, etc.
Antti Koivisto
Comment 1
2022-03-16 09:30:08 PDT
Created
attachment 454846
[details]
Patch
Antti Koivisto
Comment 2
2022-03-16 10:36:16 PDT
Created
attachment 454857
[details]
Patch
Antti Koivisto
Comment 3
2022-03-16 10:45:00 PDT
Created
attachment 454862
[details]
Patch
Antti Koivisto
Comment 4
2022-03-16 11:56:50 PDT
Created
attachment 454874
[details]
Patch
Antti Koivisto
Comment 5
2022-03-16 12:00:31 PDT
Created
attachment 454876
[details]
Patch
Antti Koivisto
Comment 6
2022-03-16 13:13:42 PDT
Created
attachment 454886
[details]
Patch
Antoine Quint
Comment 7
2022-03-17 01:44:38 PDT
Comment on
attachment 454886
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=454886&action=review
> Source/WebCore/css/CSSToLengthConversionData.h:52 > + CSSToLengthConversionData(const RenderStyle&, const RenderStyle* rootStyle, const RenderStyle* parentStyle, const RenderView*);
'zoom' v. `zoom`, who should win?
> Source/WebCore/css/MediaQueryEvaluator.cpp:949 > + return function(expression.value(), { *m_style, &defaultStyle, nullptr, document.renderView() }, *frame, NoPrefix);
Should we ASSERT(m_style) here?
Antti Koivisto
Comment 8
2022-03-17 01:53:11 PDT
> Should we ASSERT(m_style) here?
Nah, there is a null test pretty close above.
EWS
Comment 9
2022-03-17 02:42:16 PDT
Committed
r291398
(
248528@main
): <
https://commits.webkit.org/248528@main
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 454886
[details]
.
Radar WebKit Bug Importer
Comment 10
2022-03-17 02:43:18 PDT
<
rdar://problem/90419727
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug