Bug 237946 - Only show notification permission prompt on user gesture
Summary: Only show notification permission prompt on user gesture
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ben Nham
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-03-16 00:54 PDT by Ben Nham
Modified: 2022-03-17 12:08 PDT (History)
6 users (show)

See Also:

Attachments
Patch (31.51 KB, patch)
2022-03-16 00:56 PDT, Ben Nham 		no flags Details | Formatted Diff | Diff
Patch (34.69 KB, patch)
2022-03-16 10:26 PDT, Ben Nham 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ben Nham 2022-03-16 00:54:26 PDT 
Only show notification permission prompt on user gesture
Comment 1 Ben Nham 2022-03-16 00:56:00 PDT 
Created attachment 454807 [details]
Patch
Comment 2 Ben Nham 2022-03-16 00:58:10 PDT 
rdar://88821287
Comment 3 Ben Nham 2022-03-16 10:26:54 PDT 
Created attachment 454855 [details]
Patch
Comment 4 Geoffrey Garen 2022-03-16 10:31:51 PDT 
Comment on attachment 454855 [details]
Patch

r=me
Comment 5 EWS 2022-03-17 09:53:26 PDT 
Committed r291414 (248542@main): <https://commits.webkit.org/248542@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 454855 [details].
Comment 6 Ben Nham 2022-03-17 12:08:35 PDT 
This was also needed to fix an API test build failure on iOS:

https://trac.webkit.org/changeset/291427/webkit/