Bug 237944 - [GPU Process] [GraphicsContextState 1/] Move other classes out of GraphicsContext.h
Summary: [GPU Process] [GraphicsContextState 1/] Move other classes out of GraphicsCon...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Said Abou-Hallawa
URL:
Keywords: InRadar
Depends on:
Blocks: 237728
  Show dependency tree / graph
 
Reported: 2022-03-15 23:22 PDT by Said Abou-Hallawa
Modified: 2022-03-16 13:54 PDT (History)
9 users (show)

See Also:

Attachments
Patch (85.17 KB, patch)
2022-03-16 01:33 PDT, Said Abou-Hallawa 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (85.30 KB, patch)
2022-03-16 01:44 PDT, Said Abou-Hallawa 		no flags Details | Formatted Diff | Diff
Patch (85.66 KB, patch)
2022-03-16 10:37 PDT, Said Abou-Hallawa 		simon.fraser: review+
Details | Formatted Diff | Diff
Patch (85.62 KB, patch)
2022-03-16 11:46 PDT, Said Abou-Hallawa 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Said Abou-Hallawa 2022-03-15 23:22:31 PDT 
This GraphicsContext class is big by itself. So let's have GraphicsContext.h be a header file for GraphicsContext only. The plan is to make GraphicsContextState a class and make it handle its encoding and decoding.
Comment 1 Said Abou-Hallawa 2022-03-16 01:33:10 PDT 
Created attachment 454809 [details]
Patch
Comment 2 Said Abou-Hallawa 2022-03-16 01:44:08 PDT 
Created attachment 454810 [details]
Patch
Comment 3 Said Abou-Hallawa 2022-03-16 10:37:55 PDT 
Created attachment 454859 [details]
Patch
Comment 4 Simon Fraser (smfr) 2022-03-16 11:13:36 PDT 
Comment on attachment 454859 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454859&action=review

> Source/WebCore/platform/graphics/TextBoxIterator.h:36
> +        : m_textRun(0)
> +        , m_offset(0)

Use initializers and make this = default.
Comment 5 Said Abou-Hallawa 2022-03-16 11:46:35 PDT 
Created attachment 454871 [details]
Patch
Comment 6 EWS 2022-03-16 13:53:30 PDT 
Committed r291364 (248496@main): <https://commits.webkit.org/248496@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 454871 [details].
Comment 7 Radar WebKit Bug Importer 2022-03-16 13:54:34 PDT 
<rdar://problem/90390439>