WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
237931
Remove unused directory local variable in pas_enumerate_segregated_heaps.
https://bugs.webkit.org/show_bug.cgi?id=237931
Summary
Remove unused directory local variable in pas_enumerate_segregated_heaps.
Mark Lam
Reported
2022-03-15 16:14:19 PDT
Also remove the call to pas_unwrap_local_view_cache_node(). It doesn't add any value. The only thing of substance that it does is a PAS_ASSERT that turns out to be redundant because pas_enumerate_segregated_heaps() already asserts the same thing before calling pas_unwrap_local_view_cache_node().
Attachments
proposed patch.
(1.83 KB, patch)
2022-03-15 16:19 PDT
,
Mark Lam
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Mark Lam
Comment 1
2022-03-15 16:19:26 PDT
Created
attachment 454769
[details]
proposed patch.
Geoffrey Garen
Comment 2
2022-03-15 16:25:26 PDT
Comment on
attachment 454769
[details]
proposed patch. r=me
Mark Lam
Comment 3
2022-03-15 19:59:26 PDT
Comment on
attachment 454769
[details]
proposed patch. Thanks for the review.
EWS
Comment 4
2022-03-15 20:52:13 PDT
Committed
r291328
(
248467@main
): <
https://commits.webkit.org/248467@main
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 454769
[details]
.
Radar WebKit Bug Importer
Comment 5
2022-03-15 20:53:17 PDT
<
rdar://problem/90348452
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug