Bug 237931 - Remove unused directory local variable in pas_enumerate_segregated_heaps.
Summary: Remove unused directory local variable in pas_enumerate_segregated_heaps.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: bmalloc (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-03-15 16:14 PDT by Mark Lam
Modified: 2022-03-15 20:53 PDT (History)
2 users (show)

See Also:

Attachments
proposed patch. (1.83 KB, patch)
2022-03-15 16:19 PDT, Mark Lam 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2022-03-15 16:14:19 PDT 
Also remove the call to pas_unwrap_local_view_cache_node().  It doesn't add any value.  The only thing of substance that it does is a PAS_ASSERT that turns out to be redundant because pas_enumerate_segregated_heaps() already asserts the same thing before calling pas_unwrap_local_view_cache_node().
Comment 1 Mark Lam 2022-03-15 16:19:26 PDT 
Created attachment 454769 [details]
proposed patch.
Comment 2 Geoffrey Garen 2022-03-15 16:25:26 PDT 
Comment on attachment 454769 [details]
proposed patch.

r=me
Comment 3 Mark Lam 2022-03-15 19:59:26 PDT 
Comment on attachment 454769 [details]
proposed patch.

Thanks for the review.
Comment 4 EWS 2022-03-15 20:52:13 PDT 
Committed r291328 (248467@main): <https://commits.webkit.org/248467@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 454769 [details].
Comment 5 Radar WebKit Bug Importer 2022-03-15 20:53:17 PDT 
<rdar://problem/90348452>