Bug 237915 - Suspend newly created NetworkStorageManager if network process is or will be suspended
Summary: Suspend newly created NetworkStorageManager if network process is or will be ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Website Storage (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sihui Liu
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-03-15 12:49 PDT by Sihui Liu
Modified: 2022-03-16 00:22 PDT (History)
3 users (show)

See Also:

Attachments
Patch (3.39 KB, patch)
2022-03-15 13:03 PDT, Sihui Liu 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (3.39 KB, patch)
2022-03-15 13:25 PDT, Sihui Liu 		no flags Details | Formatted Diff | Diff
Patch for landing (3.88 KB, patch)
2022-03-15 21:22 PDT, Sihui Liu 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sihui Liu 2022-03-15 12:49:23 PDT 
...
Comment 1 Sihui Liu 2022-03-15 13:03:44 PDT 
Created attachment 454746 [details]
Patch
Comment 2 Sihui Liu 2022-03-15 13:25:33 PDT 
Created attachment 454748 [details]
Patch
Comment 3 Chris Dumez 2022-03-15 15:46:23 PDT 
Comment on attachment 454748 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454748&action=review

> Source/WebKit/NetworkProcess/NetworkProcess.cpp:2159
> +    m_isSuspended = false;

Please move this inside NetworkProcess::resume().

Alternatively, we could move the logic from resume() to here as I don't think it is needed anymore. I think we use to have the logic in resume() so we could call it from here and in suspension cancellation. However, I don't think suspension cancellation is a thing anymore.
Comment 4 Sihui Liu 2022-03-15 21:22:27 PDT 
Created attachment 454795 [details]
Patch for landing
Comment 5 EWS 2022-03-16 00:21:11 PDT 
Committed r291334 (248473@main): <https://commits.webkit.org/248473@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 454795 [details].
Comment 6 Radar WebKit Bug Importer 2022-03-16 00:22:16 PDT 
<rdar://problem/90355365>